You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mina.apache.org by tr...@apache.org on 2007/10/26 11:46:42 UTC
svn commit: r588587 -
/mina/trunk/core/src/main/java/org/apache/mina/filter/firewall/BlacklistFilter.java
Author: trustin
Date: Fri Oct 26 02:46:41 2007
New Revision: 588587
URL: http://svn.apache.org/viewvc?rev=588587&view=rev
Log:
Added a fixme mark to BlacklistFilter
Modified:
mina/trunk/core/src/main/java/org/apache/mina/filter/firewall/BlacklistFilter.java
Modified: mina/trunk/core/src/main/java/org/apache/mina/filter/firewall/BlacklistFilter.java
URL: http://svn.apache.org/viewvc/mina/trunk/core/src/main/java/org/apache/mina/filter/firewall/BlacklistFilter.java?rev=588587&r1=588586&r2=588587&view=diff
==============================================================================
--- mina/trunk/core/src/main/java/org/apache/mina/filter/firewall/BlacklistFilter.java (original)
+++ mina/trunk/core/src/main/java/org/apache/mina/filter/firewall/BlacklistFilter.java Fri Oct 26 02:46:41 2007
@@ -65,6 +65,7 @@
* Sets the addresses to be blacklisted.
*
* NOTE: this call will remove any previously blacklisted addresses.
+ * FIXME: Change the parameter type to Iterable
*
* @param addresses a collection of InetAddress objects representing the
* addresses to be blacklisted.
Re: svn commit: r588587 - /mina/trunk/core/src/main/java/org/apache/mina/filter/firewall/BlacklistFilter.java
Posted by Mark <el...@gmail.com>.
Should be taken care of....
On 10/26/07, trustin@apache.org <tr...@apache.org> wrote:
> Author: trustin
> Date: Fri Oct 26 02:46:41 2007
> New Revision: 588587
>
> URL: http://svn.apache.org/viewvc?rev=588587&view=rev
> Log:
> Added a fixme mark to BlacklistFilter
>
> Modified:
> mina/trunk/core/src/main/java/org/apache/mina/filter/firewall/BlacklistFilter.java
>
> Modified: mina/trunk/core/src/main/java/org/apache/mina/filter/firewall/BlacklistFilter.java
> URL: http://svn.apache.org/viewvc/mina/trunk/core/src/main/java/org/apache/mina/filter/firewall/BlacklistFilter.java?rev=588587&r1=588586&r2=588587&view=diff
> ==============================================================================
> --- mina/trunk/core/src/main/java/org/apache/mina/filter/firewall/BlacklistFilter.java (original)
> +++ mina/trunk/core/src/main/java/org/apache/mina/filter/firewall/BlacklistFilter.java Fri Oct 26 02:46:41 2007
> @@ -65,6 +65,7 @@
> * Sets the addresses to be blacklisted.
> *
> * NOTE: this call will remove any previously blacklisted addresses.
> + * FIXME: Change the parameter type to Iterable
> *
> * @param addresses a collection of InetAddress objects representing the
> * addresses to be blacklisted.
>
>
>
--
--------------------------------
The adjuration to be "normal" seems shockingly repellent to me; I see
neither hope nor comfort in sinking to that low level. I think it is
ignorance that makes people think of abnormality only with horror and
allows them to remain undismayed at the proximity of "normal" to
average and mediocre. For surely anyone who achieves anything is,
essentially, abnormal.
Dr. Karl Menninger