[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4703: esp32s2: Add RNG driver support and board profile example

[GitBox <gi...@apache.org>]

gustavonihei commented on a change in pull request #4703:
URL: https://github.com/apache/incubator-nuttx/pull/4703#discussion_r732144235



##########
File path: arch/xtensa/src/esp32s2/Make.defs
##########
@@ -77,6 +77,10 @@ ifeq ($(CONFIG_ESP32S2_UART),y)
 CMN_CSRCS += esp32s2_serial.c
 endif
 
+ifeq ($(CONFIG_ESP32S2_RNG),y)
+CMN_CSRCS += esp32s2_rng.c

Review comment:
       ```suggestion
   CHIP_CSRCS += esp32s2_rng.c
   ```
   RNG is specific to ESP32-S2.
   
   There are other mistakes like this in this `Make.defs` file: `esp32s2_systemreset.c`, `esp32s2_idle.c`, `esp32s2_serial.c`.
   `

##########
File path: arch/xtensa/src/esp32s2/Make.defs
##########
@@ -77,6 +77,10 @@ ifeq ($(CONFIG_ESP32S2_UART),y)
 CMN_CSRCS += esp32s2_serial.c
 endif
 
+ifeq ($(CONFIG_ESP32S2_RNG),y)
+CMN_CSRCS += esp32s2_rng.c

Review comment:
       ```suggestion
   CHIP_CSRCS += esp32s2_rng.c
   ```
   RNG is specific to ESP32-S2.
   
   There are other mistakes like this in this `Make.defs` file: `esp32s2_systemreset.c`, `esp32s2_idle.c`, `esp32s2_serial.c`.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org