[GitHub] [druid] suneet-s commented on pull request #11429: Implement configurable internally generated query context

[GitBox <gi...@apache.org>]

suneet-s commented on pull request #11429:
URL: https://github.com/apache/druid/pull/11429#issuecomment-933788660


   > > seems reasonable to me.
   > > What sort of integration test do you think would be needed to validate this change?
   > 
   > Ya, I have continued to think about an integration test here but I am not sure there is anything straightforward. In a live cluster, the only way to test that the context override is honored would be by analyzing query metric output or query log output (at least that I can think of). So I plan to instead look at DruidSchema for opportunities to test that the config is honored
   
   Sounds good to me. I think if there is a unit test that validates the context in BrokerInternalQueryConfigTest is used by the DruidSchema#runSegmentMetadataQuery method - that should be sufficient testing to get this change merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org