[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678439#comment-16678439 ] 

ASF GitHub Bot commented on SLING-8032:
---------------------------------------

bosschaert commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436676367
 
 
   Hi @simonetripodi - is this PR still good to go in after the recent refactoring of the codebase? 
   The code itself looks good to me. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> ------------------------------------------------------------------------------
>
>                 Key: SLING-8032
>                 URL: https://issues.apache.org/jira/browse/SLING-8032
>             Project: Sling
>          Issue Type: Improvement
>          Components: Feature Model, Maven Plugins and Archetypes
>            Reporter: Simone Tripodi
>            Assignee: David Bosschaert
>            Priority: Major
>             Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to contribute a simple MOJO which is able to validate Feature files against the Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation, since {{Feature}} instances are parsed already here, anyway the {{Analyser}} takes in charge semantic analysis, while JSON Schema validation is is strict about syntax and structure, this is why I would have a separated MOJO which can be optionally enabled.
> PR is coming



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)