You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2020/08/20 14:05:48 UTC
[GitHub] [systemds] kev-inn opened a new pull request #1032: [SYSTEMDS-2558,2554,2561] Federated transform apply
kev-inn opened a new pull request #1032:
URL: https://github.com/apache/systemds/pull/1032
Adds the federated `transformapply` instruction.
## Status
Of the `transform` category only `transformcolmap` and `transformmeta` are missing federated implementations (both are still missing some documentation too btw). Currently the federated `transforms` are still missing `binning`, `mvi` (Missing value handling by imputation) and `omit` (Missing value handling by omitting).
## Merge
Merge PR #1031 and #1027 first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] mboehm7 commented on pull request #1032: [SYSTEMDS-2558,2554,2561,2556,2557,2559] Federated transform apply + binning and omit
Posted by GitBox <gi...@apache.org>.
mboehm7 commented on pull request #1032:
URL: https://github.com/apache/systemds/pull/1032#issuecomment-683346419
Oh, and I moved the new test to federated.transform as we refactored the related sub-packages and github actions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] asfgit closed pull request #1032: [SYSTEMDS-2558,2554,2561,2556,2557,2559] Federated transform apply + binning and omit
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1032:
URL: https://github.com/apache/systemds/pull/1032
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] mboehm7 commented on pull request #1032: [SYSTEMDS-2558,2554,2561,2556,2557,2559] Federated transform apply + binning and omit
Posted by GitBox <gi...@apache.org>.
mboehm7 commented on pull request #1032:
URL: https://github.com/apache/systemds/pull/1032#issuecomment-683346259
LGTM - thanks for this extension @kev-inn. Overall, this looks very good. I just made some formatting changes, fixed the merge conflicts, fixed a missing frame block release in `GetColumnNames` and `InitRowsToRemoveOmit`, and left a performance TODO in the `EncoderOmit`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org