You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/06 09:28:11 UTC

[GitHub] [airflow] Junnplus opened a new pull request #13508: Separate nodeSelector logic of chart

Junnplus opened a new pull request #13508:
URL: https://github.com/apache/airflow/pull/13508


   Fix https://github.com/apache/airflow/issues/10761
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on a change in pull request #13508: Separate nodeSelector logic of chart

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13508:
URL: https://github.com/apache/airflow/pull/13508#discussion_r553052218



##########
File path: chart/values.yaml
##########
@@ -624,6 +659,11 @@ cleanup:
   # Run every 15 minutes
   schedule: "*/15 * * * *"
 
+  # Select certain nodes for airflow cleanup pods.
+  nodeSelector: {}
+  affinity: {}
+  tolerations: []

Review comment:
       values table in Readme does not contain this values for cleanup, redis, pgbouncer and other pods




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil merged pull request #13508: Separate nodeSelector logic of chart

Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13508:
URL: https://github.com/apache/airflow/pull/13508


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] Junnplus commented on a change in pull request #13508: Separate nodeSelector logic of chart

Posted by GitBox <gi...@apache.org>.
Junnplus commented on a change in pull request #13508:
URL: https://github.com/apache/airflow/pull/13508#discussion_r553362673



##########
File path: chart/values.yaml
##########
@@ -624,6 +659,11 @@ cleanup:
   # Run every 15 minutes
   schedule: "*/15 * * * *"
 
+  # Select certain nodes for airflow cleanup pods.
+  nodeSelector: {}
+  affinity: {}
+  tolerations: []

Review comment:
       added.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org