[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #5988: Fetch Brokers From Controller in JDBC

[GitBox <gi...@apache.org>]

KKcorps commented on a change in pull request #5988:
URL: https://github.com/apache/incubator-pinot/pull/5988#discussion_r484713514



##########
File path: pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/controller/PinotControllerTransport.java
##########
@@ -77,13 +76,31 @@ public SchemaResponse getTableSchema(String table, String controllerAddress) {
       final Future<Response> response =
           requestBuilder.addHeader("Content-Type", "application/json; charset=utf-8").execute();
 
-      SchemaResponseFuture schemaResponseFuture = new SchemaResponseFuture(response, url);
+      SchemaResponse.SchemaResponseFuture schemaResponseFuture = new SchemaResponse.SchemaResponseFuture(response, url);
       return schemaResponseFuture.get();
     } catch (ExecutionException e) {
       throw new PinotClientException(e);
     }
   }
 
+  public ControllerTenantBrokerResponse getBrokersFromController(String controllerAddress, String tenant) {

Review comment:
       every connection creation.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org