You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by sospartan <gi...@git.apache.org> on 2017/03/17 07:08:30 UTC
[GitHub] incubator-weex pull request #125: [android] refactor list sticky implementat...
GitHub user sospartan opened a pull request:
https://github.com/apache/incubator-weex/pull/125
[android] refactor list sticky implementation
Use list instead of stack to store sticky components and views.
In list, use #updateSticyView(currentStickyPos) to find the current sticky component.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sospartan/incubator-weex 0.12-dev-non-stack-sticky
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/125.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #125
----
commit 06da8bc346651f2ff297fb3b77aead9c44d19aec
Author: sospartan <so...@apache.org>
Date: 2017-03-17T07:07:04Z
* [android] refactor sticky implementation in list
Use list instead of stack to store sticky components and views.
In list, use #updateSticyView(currentStickyPos) to find the current sticky component.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #125: [android] refactor list sticky implementation
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/125
<!--
0 failure:
2 warning: Potential BREAK C..., Potential BREAK C...
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/list/SimpleRecyclerView.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
</tr>
<tr>
<td>:warning:</td>
<td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/view/refresh/wrapper/BounceRecyclerView.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #125: [android] refactor list sticky implementat...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/125
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---