You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sis.apache.org by Travis Pinney <tr...@gmail.com> on 2013/06/04 04:19:05 UTC
Review Request: Experimental Shapefile driver. Implements reading of
Polygons, Points, and Polylines from Shapefiles.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11615/
-----------------------------------------------------------
Review request for sis, Chris Mattmann, Adam Estrada, and Martin Desruisseaux.
Description
-------
Experimental Shapefile driver. Implements reading of Polygons, Points, and Polylines from Shapefiles.
This addresses bug SIS-100.
https://issues.apache.org/jira/browse/SIS-100
Diffs
-----
/repos/asf/sis/trunk/storage/sis-shapefile/data/ABRALicenseePt_4326_clipped.dbf PRE-CREATION
/repos/asf/sis/trunk/storage/sis-shapefile/data/ABRALicenseePt_4326_clipped.prj PRE-CREATION
/repos/asf/sis/trunk/storage/sis-shapefile/data/ABRALicenseePt_4326_clipped.shp PRE-CREATION
/repos/asf/sis/trunk/storage/sis-shapefile/data/ABRALicenseePt_4326_clipped.shx PRE-CREATION
/repos/asf/sis/trunk/storage/sis-shapefile/data/ANC90Ply_4326.dbf PRE-CREATION
/repos/asf/sis/trunk/storage/sis-shapefile/data/ANC90Ply_4326.prj PRE-CREATION
/repos/asf/sis/trunk/storage/sis-shapefile/data/ANC90Ply_4326.shp PRE-CREATION
/repos/asf/sis/trunk/storage/sis-shapefile/data/ANC90Ply_4326.shx PRE-CREATION
/repos/asf/sis/trunk/storage/sis-shapefile/data/NOTES.md PRE-CREATION
/repos/asf/sis/trunk/storage/sis-shapefile/data/SignedBikeRoute_4326_clipped.dbf PRE-CREATION
/repos/asf/sis/trunk/storage/sis-shapefile/data/SignedBikeRoute_4326_clipped.prj PRE-CREATION
/repos/asf/sis/trunk/storage/sis-shapefile/data/SignedBikeRoute_4326_clipped.shp PRE-CREATION
/repos/asf/sis/trunk/storage/sis-shapefile/data/SignedBikeRoute_4326_clipped.shx PRE-CREATION
/repos/asf/sis/trunk/storage/sis-shapefile/pom.xml PRE-CREATION
/repos/asf/sis/trunk/storage/sis-shapefile/src/main/java/org/apache/sis/storage/shapefile/App.java PRE-CREATION
/repos/asf/sis/trunk/storage/sis-shapefile/src/main/java/org/apache/sis/storage/shapefile/Feature.java PRE-CREATION
/repos/asf/sis/trunk/storage/sis-shapefile/src/main/java/org/apache/sis/storage/shapefile/FieldDescriptor.java PRE-CREATION
/repos/asf/sis/trunk/storage/sis-shapefile/src/main/java/org/apache/sis/storage/shapefile/ShapeFile.java PRE-CREATION
/repos/asf/sis/trunk/storage/sis-shapefile/src/main/java/org/apache/sis/storage/shapefile/ShapeTypeEnum.java PRE-CREATION
/repos/asf/sis/trunk/storage/sis-shapefile/src/test/java/org/apache/sis/storage/shapefile/test/AppTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/11615/diff/
Testing
-------
Thanks,
Travis Pinney
Re: Review Request: Experimental Shapefile driver. Implements reading of
Polygons, Points, and Polylines from Shapefiles.
Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11615/#review21458
-----------------------------------------------------------
/repos/asf/sis/trunk/storage/sis-shapefile/pom.xml
<https://reviews.apache.org/r/11615/#comment44444>
Is this really the version? Seems to be a weird #.
/repos/asf/sis/trunk/storage/sis-shapefile/src/main/java/org/apache/sis/storage/shapefile/App.java
<https://reviews.apache.org/r/11615/#comment44445>
Maybe call this CmdLineDriver instead of App (non descriptive?)
/repos/asf/sis/trunk/storage/sis-shapefile/src/main/java/org/apache/sis/storage/shapefile/App.java
<https://reviews.apache.org/r/11615/#comment44446>
Class looks like it could be a unit test..
/repos/asf/sis/trunk/storage/sis-shapefile/src/main/java/org/apache/sis/storage/shapefile/Feature.java
<https://reviews.apache.org/r/11615/#comment44447>
maybe explicitly declare these private?
/repos/asf/sis/trunk/storage/sis-shapefile/src/test/java/org/apache/sis/storage/shapefile/test/AppTest.java
<https://reviews.apache.org/r/11615/#comment44448>
should replace with actual contents of App class now since that actually tests something. :)
- Chris Mattmann
On June 4, 2013, 2:19 a.m., Travis Pinney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11615/
> -----------------------------------------------------------
>
> (Updated June 4, 2013, 2:19 a.m.)
>
>
> Review request for sis, Chris Mattmann, Adam Estrada, and Martin Desruisseaux.
>
>
> Description
> -------
>
> Experimental Shapefile driver. Implements reading of Polygons, Points, and Polylines from Shapefiles.
>
>
> This addresses bug SIS-100.
> https://issues.apache.org/jira/browse/SIS-100
>
>
> Diffs
> -----
>
> /repos/asf/sis/trunk/storage/sis-shapefile/data/ABRALicenseePt_4326_clipped.dbf PRE-CREATION
> /repos/asf/sis/trunk/storage/sis-shapefile/data/ABRALicenseePt_4326_clipped.prj PRE-CREATION
> /repos/asf/sis/trunk/storage/sis-shapefile/data/ABRALicenseePt_4326_clipped.shp PRE-CREATION
> /repos/asf/sis/trunk/storage/sis-shapefile/data/ABRALicenseePt_4326_clipped.shx PRE-CREATION
> /repos/asf/sis/trunk/storage/sis-shapefile/data/ANC90Ply_4326.dbf PRE-CREATION
> /repos/asf/sis/trunk/storage/sis-shapefile/data/ANC90Ply_4326.prj PRE-CREATION
> /repos/asf/sis/trunk/storage/sis-shapefile/data/ANC90Ply_4326.shp PRE-CREATION
> /repos/asf/sis/trunk/storage/sis-shapefile/data/ANC90Ply_4326.shx PRE-CREATION
> /repos/asf/sis/trunk/storage/sis-shapefile/data/NOTES.md PRE-CREATION
> /repos/asf/sis/trunk/storage/sis-shapefile/data/SignedBikeRoute_4326_clipped.dbf PRE-CREATION
> /repos/asf/sis/trunk/storage/sis-shapefile/data/SignedBikeRoute_4326_clipped.prj PRE-CREATION
> /repos/asf/sis/trunk/storage/sis-shapefile/data/SignedBikeRoute_4326_clipped.shp PRE-CREATION
> /repos/asf/sis/trunk/storage/sis-shapefile/data/SignedBikeRoute_4326_clipped.shx PRE-CREATION
> /repos/asf/sis/trunk/storage/sis-shapefile/pom.xml PRE-CREATION
> /repos/asf/sis/trunk/storage/sis-shapefile/src/main/java/org/apache/sis/storage/shapefile/App.java PRE-CREATION
> /repos/asf/sis/trunk/storage/sis-shapefile/src/main/java/org/apache/sis/storage/shapefile/Feature.java PRE-CREATION
> /repos/asf/sis/trunk/storage/sis-shapefile/src/main/java/org/apache/sis/storage/shapefile/FieldDescriptor.java PRE-CREATION
> /repos/asf/sis/trunk/storage/sis-shapefile/src/main/java/org/apache/sis/storage/shapefile/ShapeFile.java PRE-CREATION
> /repos/asf/sis/trunk/storage/sis-shapefile/src/main/java/org/apache/sis/storage/shapefile/ShapeTypeEnum.java PRE-CREATION
> /repos/asf/sis/trunk/storage/sis-shapefile/src/test/java/org/apache/sis/storage/shapefile/test/AppTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/11615/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Travis Pinney
>
>