[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #11542: [improvement] The default worker grouping supports editing

[GitBox <gi...@apache.org>]

ruanwenjun commented on code in PR #11542:
URL: https://github.com/apache/dolphinscheduler/pull/11542#discussion_r948856832


##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/WorkerGroup.java:
##########
@@ -92,16 +94,24 @@ public void setSystemDefault(boolean systemDefault) {
         this.systemDefault = systemDefault;
     }
 
+    public String getDescription() {
+        return description;
+    }
+
+    public void setDescription(String description) {
+        this.description = description;
+    }
+
     @Override
     public String toString() {
-        return "WorkerGroup{"
-                + "id= " + id
-                + ", name= " + name
-                + ", addrList= " + addrList
-                + ", createTime= " + createTime
-                + ", updateTime= " + updateTime
-                + ", systemDefault= " + systemDefault
-                + "}";
+        return "WorkerGroup{" +
+                "id=" + id +
+                ", name='" + name + '\'' +
+                ", addrList='" + addrList + '\'' +
+                ", createTime=" + createTime +
+                ", updateTime=" + updateTime +
+                ", description='" + description + '\'' +
+                ", systemDefault=" + systemDefault +
+                '}';

Review Comment:
   Please remove this and use Lombok.



##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkerGroupServiceImpl.java:
##########
@@ -122,6 +123,7 @@ public Map<String, Object> saveWorkerGroup(User loginUser, int id, String name,
             return result;
         }
         if (workerGroup.getId() != 0) {
+            handleWorkGroup(workerGroup);

Review Comment:
   This is strange, I don't think we should add a handle method here, what the handle method means?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org