You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by radarwave <gi...@git.apache.org> on 2015/11/13 04:23:48 UTC
[GitHub] incubator-hawq pull request: HAWQ-40. Refact hawq standby init. Ch...
GitHub user radarwave opened a pull request:
https://github.com/apache/incubator-hawq/pull/107
HAWQ-40. Refact hawq standby init. Changes to standby int and start.
Refact hawq standby init. Change standby start sequence and do init directly on standby host(previously on master node).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/radarwave/incubator-hawq HAWQ-40
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/107.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #107
----
commit 5d4db71b050dbdce7d8269d481b919d48cd28664
Author: rlei <rl...@pivotal.io>
Date: 2015-11-13T03:08:56Z
HAWQ-40. Refact hawq standby init. Change standby start sequence and do init directly on standby host.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-40. Refact hawq standby init. Ch...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the pull request:
https://github.com/apache/incubator-hawq/pull/107#issuecomment-156324588
@denalex Ok, this commit is in, I will revert it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-40. Refact hawq standby init. Ch...
Posted by denalex <gi...@git.apache.org>.
Github user denalex commented on the pull request:
https://github.com/apache/incubator-hawq/pull/107#issuecomment-156321359
!! Please hold off on committing this change until after the Beta. Ambari HAWQ plugin will not be able to accommodate these changes for the Beta release. !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-40. Refact hawq standby init. Ch...
Posted by vVineet <gi...@git.apache.org>.
Github user vVineet commented on the pull request:
https://github.com/apache/incubator-hawq/pull/107#issuecomment-158508438
Sure, please go ahead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-40. Refact hawq standby init. Ch...
Posted by yaoj2 <gi...@git.apache.org>.
Github user yaoj2 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/107#issuecomment-156315123
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-40. Refact hawq standby init. Ch...
Posted by yaoj2 <gi...@git.apache.org>.
Github user yaoj2 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/107#discussion_r44746498
--- Diff: tools/bin/hawq_ctl ---
@@ -149,7 +153,7 @@ class HawqInit:
(source_hawq_env, self.vseg_num_per_node)
result = local_ssh(cmd, logger)
if result != 0:
- logger.warn("Set hawq_resourcemanager_query_vsegment_number_per_segment_limit failed.")
+ logger.warn("Set hawq_resourcemanager_query_vsegment_number_per_segment_limit failed")
return result
--- End diff --
hawq_resourcemanager_query_vsegment_number_per_segment_limit guc name change, you should use new guc name
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-40. Refact hawq standby init. Ch...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave closed the pull request at:
https://github.com/apache/incubator-hawq/pull/107
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-40. Refact hawq standby init. Ch...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/107#issuecomment-156315454
The fix looks good. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-40. Refact hawq standby init. Ch...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the pull request:
https://github.com/apache/incubator-hawq/pull/107#issuecomment-158262895
@denalex Please let me know if this change can be pushed in now since beta is released. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-40. Refact hawq standby init. Ch...
Posted by yaoj2 <gi...@git.apache.org>.
Github user yaoj2 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/107#discussion_r44746735
--- Diff: tools/bin/hawq_ctl ---
@@ -284,18 +308,10 @@ class HawqInit:
logger.info("Segments init successfully on nodes '%s'" % self.host_list)
if self.standby_host_name not in ('', 'None', 'none', 'NONE'):
--- End diff --
We should lower hostname first and then compare with none
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---