You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/11/01 19:13:27 UTC
[GitHub] [orc] dongjoon-hyun opened a new pull request #956: ORC-1042: Ignore unused-function C++ compile warning on CentOS 7
dongjoon-hyun opened a new pull request #956:
URL: https://github.com/apache/orc/pull/956
### What changes were proposed in this pull request?
This PR aims to recover C++ compilation on CentOS 7.
### Why are the changes needed?
Since https://github.com/apache/orc/pull/951/files, it's broken.
```
Started apache/main on centos7 at Mon Nov 1 10:20:20 AM PDT 2021
Cloning into 'orc'...
-- The C compiler identification is GNU 4.8.5
-- The CXX compiler identification is GNU 4.8.5
...
[ 39%] Building CXX object c++/src/CMakeFiles/orc.dir/io/InputStream.cc.o
In file included from /root/orc/c++/src/io/InputStream.hh:22:0,
from /root/orc/c++/src/io/InputStream.cc:20:
/root/orc/build/c++/src/Adaptor.hh:188:15: error: 'bool orc::multiplyExact(int64_t, int64_t, int64_t*)' defined but not used [-Werror=unused-function]
static bool multiplyExact(int64_t value, int64_t repetitions, int64_t* result) {
^
/root/orc/build/c++/src/Adaptor.hh:200:15: error: 'bool orc::addExact(int64_t, int64_t, int64_t*)' defined but not used [-Werror=unused-function]
static bool addExact(int64_t sum, int64_t increment, int64_t* result) {
^
cc1plus: all warnings being treated as errors
make[2]: *** [c++/src/CMakeFiles/orc.dir/io/InputStream.cc.o] Error 1
make[1]: *** [c++/src/CMakeFiles/orc.dir/all] Error 2
make: *** [all] Error 2
FAILED centos7
```
### How was this patch tested?
Manual.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #956: ORC-1042: Ignore unused-function C++ compile warning on CentOS 7
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #956:
URL: https://github.com/apache/orc/pull/956#issuecomment-956858245
Thank you for your review and approval, @williamhyun .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #956: ORC-1042: Ignore unused-function C++ compile warning on CentOS 7
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #956:
URL: https://github.com/apache/orc/pull/956#issuecomment-956553238
After fixing this, we hit another issue which is hidden by this. I'll file another JIRA for that.
```
[ 75%] Building CXX object c++/test/CMakeFiles/orc-test.dir/TestMurmur3.cc.o
/root/orc/c++/test/TestMurmur3.cc: In member function 'virtual void orc::TestMurmur3_testHash64_Test::TestBody()':
/root/orc/c++/test/TestMurmur3.cc:36:53: error: conversion to 'uint32_t {aka unsigned int}' from 'long unsigned int' may alter its value [-Werror=conversion]
uint32_t len = sizeof(origin) / sizeof(uint8_t) - 1;
^
cc1plus: all warnings being treated as errors
make[2]: *** [c++/test/CMakeFiles/orc-test.dir/TestMurmur3.cc.o] Error 1
make[1]: *** [c++/test/CMakeFiles/orc-test.dir/all] Error 2
make: *** [all] Error 2
FAILED centos7
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #956: ORC-1042: Ignore unused-function C++ compile warning on CentOS 7
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #956:
URL: https://github.com/apache/orc/pull/956#issuecomment-956544200
cc @guiyanakuang and @williamhyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #956: ORC-1042: Ignore unused-function C++ compile warning on CentOS 7
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #956:
URL: https://github.com/apache/orc/pull/956#issuecomment-956544200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #956: ORC-1042: Ignore unused-function C++ compile warning on CentOS 7
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #956:
URL: https://github.com/apache/orc/pull/956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #956: ORC-1042: Ignore unused-function C++ compile warning on CentOS 7
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #956:
URL: https://github.com/apache/orc/pull/956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #956: ORC-1042: Ignore unused-function C++ compile warning on CentOS 7
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #956:
URL: https://github.com/apache/orc/pull/956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #956: ORC-1042: Ignore unused-function C++ compile warning on CentOS 7
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #956:
URL: https://github.com/apache/orc/pull/956#issuecomment-956544200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org