You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by wassemgtk <gi...@git.apache.org> on 2016/06/30 00:31:32 UTC
[GitHub] spark pull request #13985: fuzzylogic-ML-
GitHub user wassemgtk opened a pull request:
https://github.com/apache/spark/pull/13985
fuzzylogic-ML-
Adding fuzzyLogic algorithm to spark mllib
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wassemgtk/spark mllib.fuzzylogic
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13985.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13985
----
commit cfcc08ff10cda65425fe9aabfaa9bb9457f2f465
Author: wassemgtk <wa...@gmail.com>
Date: 2016-06-30T00:29:15Z
fuzzylogic-ML-
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13985: fuzzylogic-ML-
Posted by wassemgtk <gi...@git.apache.org>.
Github user wassemgtk commented on the issue:
https://github.com/apache/spark/pull/13985
Noted, let me start from JIRA. Thanks for let me know!
> On Jun 29, 2016, at 5:46 PM, Holden Karau <no...@github.com> wrote:
>
> Hi @wassemgtk <https://github.com/wassemgtk> thanks for looking at adding more functionality to Spark. However, this doesn't appear to be done with the style guide or contribution guide in mind. You might want to take a look at the Contributing to Spark wiki page at https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark <https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark> and consider creating a JIRA to have the discussion around if this is functionality we should add in Spark or if it should be in a package as well as how to go about adding it in Spark. You might also find publishing something similar as a Spark Package could be useful.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub <https://github.com/apache/spark/pull/13985#issuecomment-229530466>, or mute the thread <https://github.com/notifications/unsubscribe/AAJGqRElNmpMISbl-tR1sMTAIgaTfwCxks5qQxHJgaJpZM4JBspJ>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13985: fuzzylogic-ML-
Posted by wassemgtk <gi...@git.apache.org>.
Github user wassemgtk closed the pull request at:
https://github.com/apache/spark/pull/13985
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13985: fuzzylogic-ML-
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13985
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13985: fuzzylogic-ML-
Posted by holdenk <gi...@git.apache.org>.
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/13985
Awesome, in the meantime it might be good to close this pull request or give it a title like [SPARK-JIRANUMBER][WIP] so other people can skip over it while you get the details sorted out :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13985: fuzzylogic-ML-
Posted by holdenk <gi...@git.apache.org>.
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/13985
Hi @wassemgtk thanks for looking at adding more functionality to Spark. However, this doesn't appear to be done with the style guide or contribution guide in mind. You might want to take a look at the Contributing to Spark wiki page at https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark and consider creating a JIRA to have the discussion around if this is functionality we should add in Spark or if it should be in a package as well as how to go about adding it in Spark. You might also find publishing something similar as a Spark Package could be useful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org