You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/31 11:43:23 UTC
[GitHub] [flink] zhuzhurk commented on a change in pull request #9268:
[FLINK-13452] Ensure to fail global when exception happens during reseting
tasks of regions
zhuzhurk commented on a change in pull request #9268: [FLINK-13452] Ensure to fail global when exception happens during reseting tasks of regions
URL: https://github.com/apache/flink/pull/9268#discussion_r309172480
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/AdaptedRestartPipelinedRegionStrategyNG.java
##########
@@ -148,19 +145,10 @@ private RestartCallback createResetAndRescheduleTasksCallback(final long globalM
} catch (GlobalModVersionMismatch e) {
throw new IllegalStateException(
"Bug: ExecutionGraph was concurrently modified outside of main thread", e);
- } catch (Exception e) {
- throw new CompletionException(e);
- }
- };
- }
-
- private BiFunction<Object, Throwable, Object> failGlobalOnError() {
Review comment:
This method is still needed for failure handling of the first part of failover process.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services