You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "czy006 (via GitHub)" <gi...@apache.org> on 2025/10/09 07:10:50 UTC
[PR] [AMORO-3810] Fix ableRuntime initialize failed when not have optimizer info for table [amoro]
czy006 opened a new pull request, #3811:
URL: https://github.com/apache/amoro/pull/3811
Fix ableRuntime initialize failed when not have optimizer info for table
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://amoro.apache.org/how-to-contribute/
2. If the PR is related to an issue in https://github.com/apache/amoro/issues, add '[AMORO-XXXX]' in your PR title, e.g., '[AMORO-XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][AMORO-XXXX] Your PR title ...'.
-->
## Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about its use case.
2. If you fix a bug, you can clarify why it is a bug.
3. Use Fix/Resolve/Close #{ISSUE_NUMBER} to link this PR to its related issue
-->
Close #3810.
## Brief change log
<!--
Clearly describe the changes made in modules, classes, methods, etc.
-->
- if restore started ams null,will be first add it
## How was this patch tested?
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] Run test locally before making a pull request
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3810] Fix tableRuntime initialize failed when not have optimizer info for table [amoro]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3811:
URL: https://github.com/apache/amoro/pull/3811#issuecomment-3590720691
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3810] Fix ableRuntime initialize failed when not have optimizer info for table [amoro]
Posted by "czy006 (via GitHub)" <gi...@apache.org>.
czy006 commented on code in PR #3811:
URL: https://github.com/apache/amoro/pull/3811#discussion_r2419711741
##########
amoro-ams/src/main/java/org/apache/amoro/server/table/DefaultTableService.java:
##########
@@ -182,6 +182,13 @@ public void initialize() {
continue;
}
List<TableRuntimeState> states = statesMap.get(tableRuntimeMeta.getTableId());
+ // if first time states will be null can't be initial table runtime
+ if (states == null) {
+ TableRuntimeState state = new TableRuntimeState();
Review Comment:
When we persist tableuntime for the first time, do we need to set OptimizingStatus to IDLE by default? Or will the subsequent optimization triggers automatically supplement this status cc @baiyangtx @zhoujinsong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3810] Fix ableRuntime initialize failed when not have optimizer info for table [amoro]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong commented on code in PR #3811:
URL: https://github.com/apache/amoro/pull/3811#discussion_r2415837821
##########
amoro-ams/src/main/java/org/apache/amoro/server/table/DefaultTableService.java:
##########
@@ -182,6 +182,13 @@ public void initialize() {
continue;
}
List<TableRuntimeState> states = statesMap.get(tableRuntimeMeta.getTableId());
+ // if first time states will be null can't be initial table runtime
+ if (states == null) {
+ TableRuntimeState state = new TableRuntimeState();
Review Comment:
Maybe we can just initialize an empty list here, https://github.com/apache/amoro/blob/master/amoro-ams/src/main/java/org/apache/amoro/server/table/DefaultTableRuntimeStore.java#L137 will generate required states and put them in the database.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3810] Fix tableRuntime initialize failed when not have optimizer info for table [amoro]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #3811: [AMORO-3810] Fix tableRuntime initialize failed when not have optimizer info for table
URL: https://github.com/apache/amoro/pull/3811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3810] Fix ableRuntime initialize failed when not have optimizer info for table [amoro]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong commented on code in PR #3811:
URL: https://github.com/apache/amoro/pull/3811#discussion_r2415839673
##########
amoro-ams/src/main/java/org/apache/amoro/server/table/DefaultTableService.java:
##########
@@ -182,6 +182,13 @@ public void initialize() {
continue;
}
List<TableRuntimeState> states = statesMap.get(tableRuntimeMeta.getTableId());
+ // if first time states will be null can't be initial table runtime
+ if (states == null) {
+ TableRuntimeState state = new TableRuntimeState();
Review Comment:
cc @baiyangtx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3810] Fix ableRuntime initialize failed when not have optimizer info for table [amoro]
Posted by "baiyangtx (via GitHub)" <gi...@apache.org>.
baiyangtx commented on code in PR #3811:
URL: https://github.com/apache/amoro/pull/3811#discussion_r2415902057
##########
amoro-ams/src/main/java/org/apache/amoro/server/table/DefaultTableService.java:
##########
@@ -182,6 +182,13 @@ public void initialize() {
continue;
}
List<TableRuntimeState> states = statesMap.get(tableRuntimeMeta.getTableId());
+ // if first time states will be null can't be initial table runtime
+ if (states == null) {
+ TableRuntimeState state = new TableRuntimeState();
Review Comment:
Additionally, stateId and OptimizingStatus are not related. TableRuntimeState represents the persistent access interface of TableRuntime, while OptimizingStatus is part of the optimization logic of Iceberg and Mixed Iceberg. The two are unrelated.
##########
amoro-ams/src/main/java/org/apache/amoro/server/table/DefaultTableService.java:
##########
@@ -182,6 +182,13 @@ public void initialize() {
continue;
}
List<TableRuntimeState> states = statesMap.get(tableRuntimeMeta.getTableId());
+ // if first time states will be null can't be initial table runtime
+ if (states == null) {
+ TableRuntimeState state = new TableRuntimeState();
Review Comment:
I agree with that.
The initialization of states should be uniformly managed by the lifecycle logic of TableRuntime, and its default values have already been defined in StateKey.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3810] Fix tableRuntime initialize failed when not have optimizer info for table [amoro]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3811:
URL: https://github.com/apache/amoro/pull/3811#issuecomment-3565042742
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@amoro.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org