You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by Lars Volker <lv...@cloudera.com> on 2018/03/02 23:55:10 UTC

Re: Please hold off on merging changes that don't fix builds

Our builds are still in a bad shape, in particular all downstream
exhaustive builds are currently failing. Tim will push a change to revert
IMPALA-4835 to address some of the issue.

Please hold off on any commits that don't address current build issues
until our builds are reliably green.

Thanks, Lars

On Mon, Feb 26, 2018 at 11:22 AM, Tim Armstrong <ta...@cloudera.com>
wrote:

> Things are in a bit better shape - we have changes successfully being
> cherry-picked to 2.x. CentOS 6 builds are running to completion and we're
> able to run S3 and LocalFS builds that use the snapshot loading path.
>
> There are still a lot of isolated test failures though and flaky tests
> causing a lot of failed builds:
> https://issues.apache.org/jira/issues/?jql=project%20%
> 3D%20IMPALA%20AND%20status%20in%20(Open%2C%20%22In%
> 20Progress%22%2C%20Reopened)%20AND%20labels%20in%20(Flaky%
> 2C%20flaky%2C%20broken-build)%20ORDER%20BY%20updated%20DESC
>
> It seems ok to open things up to smaller bug fixes, but please hold off on
> any large commits for now until builds are reliably green.
>
> On Fri, Feb 23, 2018 at 3:25 PM, Tim Armstrong <ta...@cloudera.com>
> wrote:
>
> > I'm triaging a bunch of builds now that have broken with the influx of
> > large changes this week.
> >
> > I'll continue to file JIRAs for issues are breaking builds, but for now
> > let's avoid merging anything that might make the situation worse.
> >
> > I'll send out an email once things are healthier.
> >
> > - Tim
> >
>

Re: Please hold off on merging changes that don't fix builds

Posted by Lars Volker <lv...@cloudera.com>.
A bunch of fixes made it into master and the builds look better. If you are
working on a broken-build issue, please keep looking into it. Thank you all
for the help.

Let's open the branch for commits again.

Cheers, Lars

On Fri, Mar 2, 2018 at 3:55 PM, Lars Volker <lv...@cloudera.com> wrote:

> Our builds are still in a bad shape, in particular all downstream
> exhaustive builds are currently failing. Tim will push a change to revert
> IMPALA-4835 to address some of the issue.
>
> Please hold off on any commits that don't address current build issues
> until our builds are reliably green.
>
> Thanks, Lars
>
> On Mon, Feb 26, 2018 at 11:22 AM, Tim Armstrong <ta...@cloudera.com>
> wrote:
>
>> Things are in a bit better shape - we have changes successfully being
>> cherry-picked to 2.x. CentOS 6 builds are running to completion and we're
>> able to run S3 and LocalFS builds that use the snapshot loading path.
>>
>> There are still a lot of isolated test failures though and flaky tests
>> causing a lot of failed builds:
>> https://issues.apache.org/jira/issues/?jql=project%20%3D%
>> 20IMPALA%20AND%20status%20in%20(Open%2C%20%22In%20Progress%
>> 22%2C%20Reopened)%20AND%20labels%20in%20(Flaky%2C%
>> 20flaky%2C%20broken-build)%20ORDER%20BY%20updated%20DESC
>>
>> It seems ok to open things up to smaller bug fixes, but please hold off on
>> any large commits for now until builds are reliably green.
>>
>> On Fri, Feb 23, 2018 at 3:25 PM, Tim Armstrong <ta...@cloudera.com>
>> wrote:
>>
>> > I'm triaging a bunch of builds now that have broken with the influx of
>> > large changes this week.
>> >
>> > I'll continue to file JIRAs for issues are breaking builds, but for now
>> > let's avoid merging anything that might make the situation worse.
>> >
>> > I'll send out an email once things are healthier.
>> >
>> > - Tim
>> >
>>
>
>