You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Alexander Hitchins <al...@shapeblue.com> on 2014/01/30 12:18:04 UTC

Review Request 17531: CLOUDSTACK-5440 - Added new guest OS types.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17531/
-----------------------------------------------------------

Review request for cloudstack.


Repository: cloudstack-git


Description
-------

Added new guest OS types in upgrade script.


Diffs
-----

  setup/db/db/schema-421to430.sql afad06c 

Diff: https://reviews.apache.org/r/17531/diff/


Testing
-------

Ran new SQL, no errors, checked table, contains correct data.


Thanks,

Alexander Hitchins

Re: Review Request 17531: CLOUDSTACK-5440 - Added new guest OS types.

Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17531/#review34168
-----------------------------------------------------------


Can you make these changes in master branch on schema-430to440.sql file? Since a RC has already been cut for 4.3, we can put these changes in 4.4 release so that on upgrade from 4.3; these changes will come in.


setup/db/db/schema-421to430.sql
<https://reviews.apache.org/r/17531/#comment64187>

    Can you fix the id values to 225, 226 and 227? The current values go till 224. We can begin from there. Reason being the guest_os_hypervisor table refers the field on this table by 'id'. It would be good to have fixed values for the new os types.



setup/db/db/schema-421to430.sql
<https://reviews.apache.org/r/17531/#comment64186>

    Could you make separate entries for Windows 8.1 (32 bit). and Windows 8.1 (64 bit). Similarly for Windows Server 2012 R2. Similar pattern has been followed for all windows sku.


- Devdeep Singh


On Jan. 30, 2014, 11:18 a.m., Alexander Hitchins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17531/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 11:18 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added new guest OS types in upgrade script.
> 
> 
> Diffs
> -----
> 
>   setup/db/db/schema-421to430.sql afad06c 
> 
> Diff: https://reviews.apache.org/r/17531/diff/
> 
> 
> Testing
> -------
> 
> Ran new SQL, no errors, checked table, contains correct data.
> 
> 
> Thanks,
> 
> Alexander Hitchins
> 
>

Re: Review Request 17531: CLOUDSTACK-5440 - Added new guest OS types.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17531/#review38281
-----------------------------------------------------------


Commit 10fb10f0fa4a97cc30765486f725eabae88cec9d in cloudstack's branch refs/heads/4.4 from Alex Hitchins
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=10fb10f ]

CLOUDSTACK-5440: Add missing guestos types got centos 6.5, windows 8.1 and windows server 2012 r2.

Signed-off-by: Devdeep Singh <de...@gmail.com>


- ASF Subversion and Git Services


On March 20, 2014, 11:50 a.m., Alex Hitchins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17531/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 11:50 a.m.)
> 
> 
> Review request for cloudstack and Devdeep Singh.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added new guest OS types in upgrade script.
> 
> 
> Diffs
> -----
> 
>   setup/db/db/schema-430to440.sql acc7e21 
> 
> Diff: https://reviews.apache.org/r/17531/diff/
> 
> 
> Testing
> -------
> 
> Ran new SQL, no errors, checked table, contains correct data.
> 
> 
> Thanks,
> 
> Alex Hitchins
> 
>

Re: Review Request 17531: CLOUDSTACK-5440 - Added new guest OS types.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17531/#review38284
-----------------------------------------------------------


Commit 3c0fa3a1dd98b918f570b2cd6068ba198a4a980d in cloudstack's branch refs/heads/master from Alex Hitchins
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3c0fa3a ]

CLOUDSTACK-5440: Add missing guestos types got centos 6.5, windows 8.1 and windows server 2012 r2.

Signed-off-by: Devdeep Singh <de...@gmail.com>


- ASF Subversion and Git Services


On March 20, 2014, 11:50 a.m., Alex Hitchins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17531/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 11:50 a.m.)
> 
> 
> Review request for cloudstack and Devdeep Singh.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added new guest OS types in upgrade script.
> 
> 
> Diffs
> -----
> 
>   setup/db/db/schema-430to440.sql acc7e21 
> 
> Diff: https://reviews.apache.org/r/17531/diff/
> 
> 
> Testing
> -------
> 
> Ran new SQL, no errors, checked table, contains correct data.
> 
> 
> Thanks,
> 
> Alex Hitchins
> 
>

Re: Review Request 17531: CLOUDSTACK-5440 - Added new guest OS types.

Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17531/#review38285
-----------------------------------------------------------

Ship it!


Pushed to 4.4 and master after minor updates to the patch.
1. Windows Server 2012 R2 wasn't needed as it was already added in 421to430 script.
2. Split CentoOS 6.5 into 32 and 64 bit types.

- Devdeep Singh


On March 20, 2014, 11:50 a.m., Alex Hitchins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17531/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 11:50 a.m.)
> 
> 
> Review request for cloudstack and Devdeep Singh.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added new guest OS types in upgrade script.
> 
> 
> Diffs
> -----
> 
>   setup/db/db/schema-430to440.sql acc7e21 
> 
> Diff: https://reviews.apache.org/r/17531/diff/
> 
> 
> Testing
> -------
> 
> Ran new SQL, no errors, checked table, contains correct data.
> 
> 
> Thanks,
> 
> Alex Hitchins
> 
>

Re: Review Request 17531: CLOUDSTACK-5440 - Added new guest OS types.

Posted by Alexander Hitchins <al...@shapeblue.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17531/
-----------------------------------------------------------

(Updated March 20, 2014, 11:50 a.m.)


Review request for cloudstack and Devdeep Singh.


Changes
-------

Devdeep, I've updated this review request with the amended diff. I will close the other review request.


Repository: cloudstack-git


Description
-------

Added new guest OS types in upgrade script.


Diffs (updated)
-----

  setup/db/db/schema-430to440.sql acc7e21 

Diff: https://reviews.apache.org/r/17531/diff/


Testing
-------

Ran new SQL, no errors, checked table, contains correct data.


Thanks,

Alexander Hitchins