You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/06 16:53:27 UTC
[GitHub] [spark] manubatham20 opened a new pull request #29956: Removed repeated keyword causing confusion
manubatham20 opened a new pull request #29956:
URL: https://github.com/apache/spark/pull/29956
Removed "instead of a JAR"
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29956: [DOC][MINOR] Removed repeated keyword causing confusion
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29956:
URL: https://github.com/apache/spark/pull/29956#issuecomment-704964973
**[Test build #129512 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129512/testReport)** for PR 29956 at commit [`e10e4a7`](https://github.com/apache/spark/commit/e10e4a7d1040b215a84f89d67c2e4d460372cd70).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #29956: [DOC][MINOR] pySpark usage - removed repeated keyword causing confusion
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #29956:
URL: https://github.com/apache/spark/pull/29956
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29956: [DOC][MINOR] Removed repeated keyword causing confusion
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29956:
URL: https://github.com/apache/spark/pull/29956#issuecomment-704965201
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29956: Removed repeated keyword causing confusion
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29956:
URL: https://github.com/apache/spark/pull/29956#discussion_r500653067
##########
File path: docs/submitting-applications.md
##########
@@ -76,7 +76,7 @@ locally on your laptop), it is common to use `cluster` mode to minimize network
the drivers and the executors. Currently, the standalone mode does not support cluster mode for Python
applications.
-For Python applications, simply pass a `.py` file in the place of `<application-jar>` instead of a JAR,
+For Python applications, simply pass a `.py` file in the place of `<application-jar>`,
Review comment:
I don't have a strong opinion though, this change looks okay. cc: @HyukjinKwon @srowen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29956: [DOC][MINOR] Removed repeated keyword causing confusion
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29956:
URL: https://github.com/apache/spark/pull/29956#issuecomment-705012931
It's fine by me. It would be nicer if we fill the PR description correctly though. @manubatham20 can you update PR description?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29956: [DOC][MINOR] Removed repeated keyword causing confusion
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29956:
URL: https://github.com/apache/spark/pull/29956#issuecomment-704957376
**[Test build #129512 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129512/testReport)** for PR 29956 at commit [`e10e4a7`](https://github.com/apache/spark/commit/e10e4a7d1040b215a84f89d67c2e4d460372cd70).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29956: [DOC][MINOR] Removed repeated keyword causing confusion
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29956:
URL: https://github.com/apache/spark/pull/29956#issuecomment-704965201
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29956: Removed repeated keyword causing confusion
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29956:
URL: https://github.com/apache/spark/pull/29956#issuecomment-704396213
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29956: Removed repeated keyword causing confusion
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29956:
URL: https://github.com/apache/spark/pull/29956#issuecomment-704396213
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29956: [DOC][MINOR] Removed repeated keyword causing confusion
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29956:
URL: https://github.com/apache/spark/pull/29956#issuecomment-704995308
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34117/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29956: [DOC][MINOR] Removed repeated keyword causing confusion
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29956:
URL: https://github.com/apache/spark/pull/29956#issuecomment-704608756
@manubatham20 can you fill the PR description? What confusion this PR fixes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29956: [DOC][MINOR] Removed repeated keyword causing confusion
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29956:
URL: https://github.com/apache/spark/pull/29956#issuecomment-704983159
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34117/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29956: [DOC][MINOR] Removed repeated keyword causing confusion
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29956:
URL: https://github.com/apache/spark/pull/29956#issuecomment-704396962
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #29956: [DOC][MINOR] pySpark usage - removed repeated keyword causing confusion
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #29956:
URL: https://github.com/apache/spark/pull/29956#issuecomment-705546740
Merged to master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #29956: [DOC][MINOR] pySpark usage - removed repeated keyword causing confusion
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #29956:
URL: https://github.com/apache/spark/pull/29956#issuecomment-705546740
Merged to master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] manubatham20 commented on pull request #29956: [DOC][MINOR] pySpark usage - removed repeated keyword causing confusion
Posted by GitBox <gi...@apache.org>.
manubatham20 commented on pull request #29956:
URL: https://github.com/apache/spark/pull/29956#issuecomment-705062219
> It's fine by me. It would be nicer if we fill the PR description correctly though. @manubatham20 can you update PR description?
It's a minor change, I have updated as per my understanding. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #29956: [DOC][MINOR] pySpark usage - removed repeated keyword causing confusion
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #29956:
URL: https://github.com/apache/spark/pull/29956
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29956: [DOC][MINOR] Removed repeated keyword causing confusion
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29956:
URL: https://github.com/apache/spark/pull/29956#issuecomment-704995337
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29956: [DOC][MINOR] Removed repeated keyword causing confusion
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29956:
URL: https://github.com/apache/spark/pull/29956#issuecomment-704957376
**[Test build #129512 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129512/testReport)** for PR 29956 at commit [`e10e4a7`](https://github.com/apache/spark/commit/e10e4a7d1040b215a84f89d67c2e4d460372cd70).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #29956: [DOC][MINOR] Removed repeated keyword causing confusion
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #29956:
URL: https://github.com/apache/spark/pull/29956#issuecomment-704952236
Jenkins test this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #29956: [DOC][MINOR] Removed repeated keyword causing confusion
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #29956:
URL: https://github.com/apache/spark/pull/29956#issuecomment-704616769
It's trivial but seems OK to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29956: [DOC][MINOR] Removed repeated keyword causing confusion
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29956:
URL: https://github.com/apache/spark/pull/29956#issuecomment-704995337
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org