You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/08 17:20:04 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25075: [SPARK-28261][CORE] Fix client reuse test

dongjoon-hyun commented on a change in pull request #25075: [SPARK-28261][CORE] Fix client reuse test
URL: https://github.com/apache/spark/pull/25075#discussion_r301209813
 
 

 ##########
 File path: common/network-common/src/test/java/org/apache/spark/network/TransportClientFactorySuite.java
 ##########
 @@ -117,7 +117,7 @@ private void testClientReuse(int maxConnections, boolean concurrent)
       }
 
       Assert.assertEquals(0, failed.get());
-      Assert.assertEquals(clients.size(), maxConnections);
+      Assert.assertTrue(clients.size() <= maxConnections);
 
 Review comment:
   Could you update the PR description if we have a previous Jenkins test failure for this, please?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org