[GitHub] [iceberg] rdblue commented on a diff in pull request #6004: Data: Support reading default values from generic Avro readers

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #6004:
URL: https://github.com/apache/iceberg/pull/6004#discussion_r1002768016


##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -412,43 +412,75 @@ public int hashCode() {
 
   public static class NestedField implements Serializable {
     public static NestedField optional(int id, String name, Type type) {
-      return new NestedField(true, id, name, type, null);
+      return new NestedField(true, id, name, type, null, null, null);
     }
 
     public static NestedField optional(int id, String name, Type type, String doc) {
-      return new NestedField(true, id, name, type, doc);
+      return new NestedField(true, id, name, type, doc, null, null);
+    }
+
+    public static NestedField optional(

Review Comment:
   I thought we talked about making these package-private until the implementation was complete so that it doesn't leak into the public API before the values are read correctly?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org