[GitHub] [solr] gerlowskija commented on a diff in pull request #1256: SOLR-10466: setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

["gerlowskija (via GitHub)" <gi...@apache.org>]

gerlowskija commented on code in PR #1256:
URL: https://github.com/apache/solr/pull/1256#discussion_r1147967826


##########
solr/core/src/test/org/apache/solr/cloud/HttpPartitionTest.java:
##########
@@ -70,7 +65,7 @@
  * Simulates HTTP partitions between a leader and replica but the replica does not lose its
  * ZooKeeper connection.
  */
-@LuceneTestCase.Nightly // there are recovery commands that take a while to time out
+// @LuceneTestCase.Nightly // there are recovery commands that take a while to time out

Review Comment:
   [Q] Is the commenting-out of the Nightly tag here temporary?  Did you mean to remove this?



##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##########
@@ -813,6 +818,11 @@ public NamedList<Object> request(SolrRequest<?> request, String collection)
     } else if (collection == null) {
       collection = defaultCollection;
     }
+    // TODO if we like this, then "defaultCollection" should be renamed

Review Comment:
   [0] IMO this would be a bit inflexible, at least for a ticket that only set out to remove a setter.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org