[GitHub] [cassandra] yifan-c commented on a diff in pull request #1905: Fix double quote parser

[GitBox <gi...@apache.org>]

yifan-c commented on code in PR #1905:
URL: https://github.com/apache/cassandra/pull/1905#discussion_r997531646


##########
src/java/org/apache/cassandra/db/marshal/UserType.java:
##########
@@ -495,7 +495,7 @@ public String toCqlString(boolean withInternals, boolean ifNotExists)
                 builder.append(",")
                        .newLine();
 
-            builder.append(fieldNameAsString(i))
+            builder.appendQuotingIfNeeded(fieldNameAsString(i))

Review Comment:
   It only fixes the user defined type. 
   As mentioned in the ticket, 
   > columns names are not quoted in materialized view, UDF and user defined aggregation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org