You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/05/03 18:57:55 UTC
[GitHub] [helix] zhangmeng916 opened a new pull request #992: Fix version comparison issue in compatibility check stage
zhangmeng916 opened a new pull request #992:
URL: https://github.com/apache/helix/pull/992
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
(#990 )
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
Currently there is a bug in the version comparison logic for compatibility check stage. It worked with all version starting with number "0". However, the comparison check would fail after we release version 1.0.0. The impact is the pipeline that includes compatibility check stage would fail due to the incompatibility error.
This PR fixed the issue by modifying the logic in the loop. If the participant version's digit number is larger than the minimum version digit number, we terminate the loop.
### Tests
- [X] The following tests are written for this issue:
TestCompatibilityCheckStage.
- [X] The following is the result of the "mvn test" command on the appropriate module:
(Copy & paste the result of "mvn test")
### Commits
- [X] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- [X] My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] zhangmeng916 commented on a change in pull request #992: Fix version comparison issue in compatibility check stage
Posted by GitBox <gi...@apache.org>.
zhangmeng916 commented on a change in pull request #992:
URL: https://github.com/apache/helix/pull/992#discussion_r419630944
##########
File path: helix-core/src/main/java/org/apache/helix/HelixManagerProperties.java
##########
@@ -116,6 +116,8 @@ static boolean versionNoLessThan(String version1, String version2) {
if (versionNum1 < versionNum2) {
return false;
+ } else if (versionNum1 > versionNum2) {
Review comment:
This is not to ignore the check. This is a digit by digit comparison. See above code, the version is already split. So we are comparing "1" to "0", which breaks the loop. If it's "0" to "0", we will continue to compare next digit. It should be complete.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] zhangmeng916 commented on a change in pull request #992: Fix version comparison issue in compatibility check stage
Posted by GitBox <gi...@apache.org>.
zhangmeng916 commented on a change in pull request #992:
URL: https://github.com/apache/helix/pull/992#discussion_r419632821
##########
File path: helix-core/src/main/java/org/apache/helix/HelixManagerProperties.java
##########
@@ -116,6 +116,8 @@ static boolean versionNoLessThan(String version1, String version2) {
if (versionNum1 < versionNum2) {
return false;
+ } else if (versionNum1 > versionNum2) {
Review comment:
Previous error is just that it didn't break even the digit is larger the minimum version. I guess it didn't consider we might bump to 1.0.0.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] zhangmeng916 commented on a change in pull request #992: Fix version comparison issue in compatibility check stage
Posted by GitBox <gi...@apache.org>.
zhangmeng916 commented on a change in pull request #992:
URL: https://github.com/apache/helix/pull/992#discussion_r419612326
##########
File path: helix-core/src/main/java/org/apache/helix/controller/stages/CompatibilityCheckStage.java
##########
@@ -55,7 +55,7 @@ public void process(ClusterEvent event) throws Exception {
"incompatible participant. pipeline will not continue. " + "controller: "
+ manager.getInstanceName() + ", controllerVersion: " + properties.getVersion()
+ ", minimumSupportedParticipantVersion: "
- + properties.getProperty("miminum_supported_version.participant")
+ + properties.getProperty("minimum_supported_version.participant")
Review comment:
And it caused the log to always show "null" for minimum support version, as it cannot find it in the property file. So the log is very confusing during debug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] lei-xia commented on a change in pull request #992: Fix version comparison issue in compatibility check stage
Posted by GitBox <gi...@apache.org>.
lei-xia commented on a change in pull request #992:
URL: https://github.com/apache/helix/pull/992#discussion_r419619115
##########
File path: helix-core/src/main/java/org/apache/helix/HelixManagerProperties.java
##########
@@ -116,6 +116,8 @@ static boolean versionNoLessThan(String version1, String version2) {
if (versionNum1 < versionNum2) {
return false;
+ } else if (versionNum1 > versionNum2) {
Review comment:
This just ignore the check, right? Can we make the logic correct here, say 1.0.x > 0.9.x?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] zhangmeng916 commented on pull request #992: Fix version comparison issue in compatibility check stage
Posted by GitBox <gi...@apache.org>.
zhangmeng916 commented on pull request #992:
URL: https://github.com/apache/helix/pull/992#issuecomment-623242085
This PR is ready to merge, approved by @dasahcc
Final commit message "Fix version comparison issue in compatibility check stage. Make sure new version number will not fail this check".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] zhangmeng916 commented on a change in pull request #992: Fix version comparison issue in compatibility check stage
Posted by GitBox <gi...@apache.org>.
zhangmeng916 commented on a change in pull request #992:
URL: https://github.com/apache/helix/pull/992#discussion_r419611245
##########
File path: helix-core/src/main/java/org/apache/helix/controller/stages/CompatibilityCheckStage.java
##########
@@ -55,7 +55,7 @@ public void process(ClusterEvent event) throws Exception {
"incompatible participant. pipeline will not continue. " + "controller: "
+ manager.getInstanceName() + ", controllerVersion: " + properties.getVersion()
+ ", minimumSupportedParticipantVersion: "
- + properties.getProperty("miminum_supported_version.participant")
+ + properties.getProperty("minimum_supported_version.participant")
Review comment:
The previous one has a typo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] dasahcc commented on a change in pull request #992: Fix version comparison issue in compatibility check stage
Posted by GitBox <gi...@apache.org>.
dasahcc commented on a change in pull request #992:
URL: https://github.com/apache/helix/pull/992#discussion_r419200909
##########
File path: helix-core/src/main/java/org/apache/helix/controller/stages/CompatibilityCheckStage.java
##########
@@ -55,7 +55,7 @@ public void process(ClusterEvent event) throws Exception {
"incompatible participant. pipeline will not continue. " + "controller: "
+ manager.getInstanceName() + ", controllerVersion: " + properties.getVersion()
+ ", minimumSupportedParticipantVersion: "
- + properties.getProperty("miminum_supported_version.participant")
+ + properties.getProperty("minimum_supported_version.participant")
Review comment:
What's the difference here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org