You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/09/19 03:45:32 UTC

[GitHub] [inlong] EMsnap commented on a diff in pull request #5780: [INLONG-5722][Agent] Support Redis Source

EMsnap commented on code in PR #5780:
URL: https://github.com/apache/inlong/pull/5780#discussion_r973843813


##########
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sources/reader/RedisReader.java:
##########
@@ -0,0 +1,445 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.agent.plugin.sources.reader;
+
+import com.google.gson.Gson;
+import com.google.gson.GsonBuilder;
+import com.google.gson.TypeAdapter;
+import com.google.gson.stream.JsonReader;
+import com.google.gson.stream.JsonWriter;
+import com.moilioncircle.redis.replicator.RedisReplicator;
+import com.moilioncircle.redis.replicator.Replicator;
+import com.moilioncircle.redis.replicator.cmd.CommandName;
+import com.moilioncircle.redis.replicator.cmd.impl.DefaultCommand;
+import com.moilioncircle.redis.replicator.cmd.parser.DefaultCommandParser;
+import com.moilioncircle.redis.replicator.event.Event;
+import com.moilioncircle.redis.replicator.event.EventListener;
+import com.moilioncircle.redis.replicator.event.PostRdbSyncEvent;
+import com.moilioncircle.redis.replicator.rdb.datatype.KeyStringValueHash;
+import com.moilioncircle.redis.replicator.rdb.datatype.KeyStringValueList;
+import com.moilioncircle.redis.replicator.rdb.datatype.KeyStringValueSet;
+import com.moilioncircle.redis.replicator.rdb.datatype.KeyStringValueString;
+import com.moilioncircle.redis.replicator.rdb.datatype.KeyStringValueZSet;
+import com.moilioncircle.redis.replicator.rdb.datatype.KeyValuePair;
+import com.moilioncircle.redis.replicator.rdb.datatype.ZSetEntry;
+import org.apache.inlong.agent.conf.JobProfile;
+import org.apache.inlong.agent.message.DefaultMessage;
+import org.apache.inlong.agent.metrics.audit.AuditUtils;
+import org.apache.inlong.agent.plugin.Message;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.net.URISyntaxException;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.LinkedBlockingQueue;
+
+/**
+ * Redis data reader
+ */
+public class RedisReader extends AbstractReader {
+
+    public static final String REDIS_READER_TAG_NAME = "AgentRedisMetric";
+    public static final String JOB_REDIS_PORT = "job.redisJob.port";
+    public static final String JOB_REDIS_HOSTNAME = "job.redisJob.hostname";
+    public static final String JOB_REDIS_SSL = "job.redisJob.ssl";
+    public static final String JOB_REDIS_AUTHUSER = "job.redisJob.authUser";
+    public static final String JOB_REDIS_AUTHPASSWORD = "job.redisJob.authPassword";
+    public static final String JOB_REDIS_READTIMEOUT = "job.redisJob.readTimeout";
+    public static final String JOB_REDIS_QUEUE_SIZE = "job.redisJob.queueSize";
+    public static final String JOB_REDIS_REPLID = "job.redisJob.replId";
+    public static final String JOB_REDIS_OFFSET = "job.redisJob.offset";
+    private static final Logger LOGGER = LoggerFactory.getLogger(RedisReader.class);
+    private String port;
+    private String hostName;
+    private boolean ssl;
+    private String authUser;
+    private String authPassword;
+    private String readTimeout;
+    private String instanceId;
+    private String replId;
+    private String snapShot;
+    private boolean destroyed;
+    private Replicator redisReplicator;
+    private LinkedBlockingQueue<String> redisMessageQueue;
+    private boolean finished = false;
+    private ExecutorService executor;
+    private Gson gson;
+
+    @Override
+    public void init(JobProfile jobConf) {
+        super.init(jobConf);
+        LOGGER.info("Init redis reader with jobConf {}", jobConf.toJsonStr());
+        port = jobConf.get(JOB_REDIS_PORT);
+        hostName = jobConf.get(JOB_REDIS_HOSTNAME);
+        ssl = jobConf.getBoolean(JOB_REDIS_SSL, false);
+        authUser = jobConf.get(JOB_REDIS_AUTHUSER, "");
+        authPassword = jobConf.get(JOB_REDIS_AUTHPASSWORD, "");
+        readTimeout = jobConf.get(JOB_REDIS_READTIMEOUT, "");
+        replId = jobConf.get(JOB_REDIS_REPLID, "");
+        snapShot = jobConf.get(JOB_REDIS_OFFSET, "-1");
+        instanceId = jobConf.getInstanceId();
+        finished = false;
+        redisMessageQueue = new LinkedBlockingQueue<>(jobConf.getInt(JOB_REDIS_QUEUE_SIZE, 10000));
+        initGson();
+        String uri = getRedisUri();
+        try {
+            redisReplicator = new RedisReplicator(uri);
+            initReplicator();
+            redisReplicator.addEventListener(new EventListener() {
+                @Override
+                public void onEvent(Replicator replicator, Event event) {
+                    try {
+                        if (event instanceof DefaultCommand || event instanceof KeyValuePair<?, ?>) {
+                            redisMessageQueue.put(gson.toJson(event));
+                            AuditUtils.add(AuditUtils.AUDIT_ID_AGENT_READ_SUCCESS, inlongGroupId, inlongStreamId,
+                                    System.currentTimeMillis(), 1);
+                            readerMetric.pluginReadCount.incrementAndGet();
+                        }
+                        if (event instanceof PostRdbSyncEvent) {
+                            snapShot = String.valueOf(replicator.getConfiguration().getReplOffset());
+                            LOGGER.info("after rdb snapShot is: {}", snapShot);
+                        }
+                    } catch (InterruptedException e) {
+                        readerMetric.pluginReadFailCount.incrementAndGet();
+                        LOGGER.error("Read redis data error", e);
+                    }
+                }
+            });
+            executor = Executors.newSingleThreadExecutor();
+            executor.execute(new Thread(() -> {
+                try {
+                    redisReplicator.open();
+                } catch (IOException e) {
+                    LOGGER.error("Redis source error", e);
+                }
+            }));
+        } catch (URISyntaxException | IOException e) {
+            readerMetric.pluginReadFailCount.addAndGet(1);
+            LOGGER.error("Connect to redis {}:{} failed.", hostName, port);
+        }
+    }
+
+    private String getRedisUri() {
+        StringBuffer sb = new StringBuffer("redis://");
+        sb.append(hostName).append(":").append(port);
+        sb.append("?");
+        if (authPassword != null && !authPassword.equals("")) {

Review Comment:
   StringUtils.isEmpty



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org