[GitHub] [gobblin] homatthew commented on a diff in pull request #3655: [GOBBLIN-1796] Log startup command when container fails to startup

["homatthew (via GitHub)" <gi...@apache.org>]

homatthew commented on code in PR #3655:
URL: https://github.com/apache/gobblin/pull/3655#discussion_r1128858010


##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnService.java:
##########
@@ -804,6 +790,55 @@ protected void handleContainerCompletion(ContainerStatus containerStatus) {
             Optional.of(completedContainerInfo.getContainer()) : Optional.absent(), newContainerResource));
   }
 
+  /**
+   * Handles containers aborted. This method handles 2 cases:
+   * <ol>
+   *   <li>
+   *     Case 1: Gobblin AM intentionally requested container to be released (often because the number of helix tasks
+   *     has decreased due to decreased traffic)
+   *   </li>
+   *   <li>
+   *     Case 2: Unexpected hardware fault and the node is lost. Need to do specific Helix logic to ensure 2 helix tasks
+   *     are not being run by the multiple containers
+   *   </li>
+   * </ol>
+   * @param containerStatus
+   * @param completedContainerInfo
+   * @param completedInstanceName
+   * @return if release request was intentionally released (Case 1)
+   */
+  private boolean handleAbortedContainer(ContainerStatus containerStatus, ContainerInfo completedContainerInfo,

Review Comment:
   Extracted from previous iteration. Added comments to explain the logic



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org