[GitHub] [superset] hughhhh commented on a change in pull request #12425: fix: import ZIP files that have been modified

[GitBox <gi...@apache.org>]

hughhhh commented on a change in pull request #12425:
URL: https://github.com/apache/superset/pull/12425#discussion_r555957398



##########
File path: superset/commands/importers/v1/utils.py
##########
@@ -73,3 +73,17 @@ def load_metadata(contents: Dict[str, str]) -> Dict[str, str]:
         raise exc
 
     return metadata
+
+
+def is_valid_config(file_name: str) -> bool:

Review comment:
       Can we get a quick unit test for this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org