DO NOT REPLY [Bug 9162] New: - DefaultCompilerAdapter should better handle bootclasspath parameter

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9162>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9162

DefaultCompilerAdapter should better handle bootclasspath parameter

           Summary: DefaultCompilerAdapter should better handle
                    bootclasspath parameter
           Product: Ant
           Version: 1.4.1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Core tasks
        AssignedTo: ant-dev@jakarta.apache.org
        ReportedBy: rodrigo_peretti@oti.com


It seems the particular implementation has not changed in 1.5 beta1.

The method DefaultCompilerAdapter.setupJavacCommandlineSwitches(...) only 
checks if the bootclasspath parameter was set. It should also check if its Path
().size() > 0 like the other compiler adapters (Jikes, Gcj, Jvc).

The use case is when a script wants to provide the ability for the user to 
choose a different bootclasspath but not make it mandatory. For Example:

<project ...>
  <property name="boot" value=""/>
  <target ...>
    <javac bootclasspath="${boot}" ...>
  </target>
<project ...>

It means the user could override the ${boot} value but does not really need to 
do so.

The proposed implementation change is from:

            if (bootclasspath != null) {
                cmd.createArgument().setValue("-bootclasspath");
                cmd.createArgument().setPath(bootclasspath);
            }

to:

            if (bootclasspath != null && bootclasspath.size() > 0) {
                cmd.createArgument().setValue("-bootclasspath");
                cmd.createArgument().setPath(bootclasspath);
            }

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>