You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2022/11/07 09:59:54 UTC
[GitHub] [incubator-pekko] jrudolph commented on a diff in pull request #20: rename actor/remote/slf4j/serialization modules
jrudolph commented on code in PR #20:
URL: https://github.com/apache/incubator-pekko/pull/20#discussion_r1015202218
##########
README.md:
##########
@@ -1,4 +1,4 @@
-Akka [](https://index.scala-lang.org/akka/akka/akka-actor)[](https://travis-ci.com/github/akka/akka)
+Akka [](https://index.scala-lang.org/akka/akka/pekko-actor)[](https://travis-ci.com/github/akka/akka)
Review Comment:
A bit weird to fix links half-way...
##########
akka-docs/src/test/java/jdocs/actor/ActorDocTest.java:
##########
@@ -841,7 +841,8 @@ public void usePatternsAskPipe() {
// using timeout from above
CompletableFuture<Object> future2 = ask(actorB, "another request", t).toCompletableFuture();
- CompletableFuture<Result> transformed = future1.thenCombine(future2, (x, s) -> new Result((String) x, (String) s));
+ CompletableFuture<Result> transformed =
Review Comment:
How did these reformats happen?
##########
build.sbt:
##########
@@ -453,30 +453,30 @@ lazy val streamTestsTck = akkaModule("akka-stream-tests-tck")
.enablePlugins(NoPublish)
.disablePlugins(MimaPlugin)
-lazy val testkit = akkaModule("akka-testkit")
+lazy val testkit = pekkoModule("akka-testkit")
.dependsOn(actor)
.settings(Dependencies.testkit)
- .settings(AutomaticModuleName.settings("akka.actor.testkit"))
+ .settings(AutomaticModuleName.settings("pekko.actor.testkit"))
.settings(OSGi.testkit)
.settings(initialCommands += "import akka.testkit._")
-lazy val actorTyped = akkaModule("akka-actor-typed")
+lazy val actorTyped = pekkoModule("pekko-actor-typed")
.dependsOn(actor, slf4j)
- .settings(AutomaticModuleName.settings("akka.actor.typed"))
+ .settings(AutomaticModuleName.settings("pekko.actor.typed"))
.settings(Dependencies.actorTyped)
.settings(OSGi.actorTyped)
.settings(initialCommands :=
"""
- import akka.actor.typed._
- import akka.actor.typed.scaladsl.Behaviors
+ import pekko.actor.typed._
Review Comment:
Was that intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org