[GitHub] [druid] clintropolis commented on a change in pull request #12241: rework sql expressions and virtual columns

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #12241:
URL: https://github.com/apache/druid/pull/12241#discussion_r801898129



##########
File path: extensions-contrib/tdigestsketch/src/main/java/org/apache/druid/query/aggregation/tdigestsketch/TDigestSketchUtils.java
##########
@@ -88,16 +86,16 @@ public static boolean matchingAggregatorFactoryExists(
   {
     // Check input for equivalence.
     final boolean inputMatches;
-    final VirtualColumn virtualInput =
-        virtualColumnRegistry.findVirtualColumns(factory.requiredFields())
+    final DruidExpression virtualInput =

Review comment:
       this pattern is done in a few places, and i think could be done more efficiently, but I avoided changing the logic at this point to reduce the number of moving parts since this PR has become a bit large




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org