You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/01/01 01:10:00 UTC
[jira] [Work logged] (HIVE-24308) FIX conditions used for DPHJ
conversion
[ https://issues.apache.org/jira/browse/HIVE-24308?focusedWorklogId=529917&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-529917 ]
ASF GitHub Bot logged work on HIVE-24308:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jan/21 01:09
Start Date: 01/Jan/21 01:09
Worklog Time Spent: 10m
Work Description: github-actions[bot] closed pull request #1604:
URL: https://github.com/apache/hive/pull/1604
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 529917)
Time Spent: 1h (was: 50m)
> FIX conditions used for DPHJ conversion
> -----------------------------------------
>
> Key: HIVE-24308
> URL: https://issues.apache.org/jira/browse/HIVE-24308
> Project: Hive
> Issue Type: Bug
> Reporter: Panagiotis Garefalakis
> Assignee: Panagiotis Garefalakis
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Found a weird scenario when looking at the ConvertJoinMapJoin logic: [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java#L1198]
> When the distinct keys cannot fit in memory AND the DPHJ ShuffleSize is lower than expected the code returns a MJ because of the condition above!
> In general, I believe the ShuffleSize check: [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java#L1624]
> should be part of the shuffleJoin DPHJ conversion.
> And the preferred conversion would be: MJ > DPHJ > SMB
--
This message was sent by Atlassian Jira
(v8.3.4#803005)