[GitHub] [arrow-rs] helgikrs commented on a change in pull request #1187: feat(parquet): support for reading structs nested within lists

[GitBox <gi...@apache.org>]

helgikrs commented on a change in pull request #1187:
URL: https://github.com/apache/arrow-rs/pull/1187#discussion_r785342933



##########
File path: parquet/src/arrow/arrow_writer.rs
##########
@@ -1770,4 +1770,104 @@ mod tests {
         let stats = column.statistics().unwrap();
         assert_eq!(stats.null_count(), 2);
     }
+
+    #[test]
+    fn test_list_of_struct_roundtrip() {

Review comment:
       This test will fail until #1185 is merged, as the data written does not match the original.

##########
File path: parquet/src/arrow/arrow_writer.rs
##########
@@ -1770,4 +1770,104 @@ mod tests {
         let stats = column.statistics().unwrap();
         assert_eq!(stats.null_count(), 2);
     }
+
+    #[test]
+    fn test_list_of_struct_roundtrip() {

Review comment:
       Note: This test will fail until #1185 is merged, as the data written does not match the original.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org