You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "zhilinli123 (via GitHub)" <gi...@apache.org> on 2023/09/21 09:50:22 UTC
[GitHub] [seatunnel] zhilinli123 opened a new pull request, #5480: [Feature][Flink] Add external configuration parameters
zhilinli123 opened a new pull request, #5480:
URL: https://github.com/apache/seatunnel/pull/5480
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 commented on pull request #5480: [feature][flink][job][conf] Add external configuration parameters
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 commented on PR #5480:
URL: https://github.com/apache/seatunnel/pull/5480#issuecomment-1722475155
### Flink Conf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 closed pull request #5480: [feature][flink][job][conf] Add external configuration parameters
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 closed pull request #5480: [feature][flink][job][conf] Add external configuration parameters
URL: https://github.com/apache/seatunnel/pull/5480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 closed pull request #5480: [feature][flink][job][conf] Add external configuration parameters
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 closed pull request #5480: [feature][flink][job][conf] Add external configuration parameters
URL: https://github.com/apache/seatunnel/pull/5480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 commented on pull request #5480: [feature][flink][job][conf] Add external configuration parameters
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 commented on PR #5480:
URL: https://github.com/apache/seatunnel/pull/5480#issuecomment-1718865266
PTAL: @ruanwenjun @TyrantLucifer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 closed pull request #5480: [feature][flink][job][conf] Add external configuration parameters
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 closed pull request #5480: [feature][flink][job][conf] Add external configuration parameters
URL: https://github.com/apache/seatunnel/pull/5480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Flink] Add external configuration parameters [seatunnel]
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 commented on PR #5480:
URL: https://github.com/apache/seatunnel/pull/5480#issuecomment-1765858283
> > #### conf file
> > ```
> > env {
> > # You can set flink configuration here
> > execution.parallelism = 2
> > job.mode = "STREAMING"
> > flink.execution.checkpointing.interval = 5000
> > flink.execution.checkpointing.unaligned.enabled = true
> > flink.execution.checkpointing.aligned-checkpoint-timeout = 100000
> > flink.jobstore.cache-size = 52428801
> > flink.state.backend.rocksdb.predefined-options = SPINNING_DISK_OPTIMIZED_HIGH_MEM
> > }
> >
> > source {
> > # This is a example source plugin **only for test and demonstrate the feature source plugin**
> > FakeSource {
> > parallelism = 2
> > result_table_name = "fake"
> > row.num = 16
> > schema = {
> > fields {
> > name = "string"
> > age = "int"
> > }
> > }
> > }
> >
> > # If you would like to get more information about how to configure seatunnel and see full list of source plugins,
> > # please go to https://seatunnel.apache.org/docs/category/source-v2
> > }
> >
> > transform {
> >
> > # If you would like to get more information about how to configure seatunnel and see full list of transform plugins,
> > # please go to https://seatunnel.apache.org/docs/category/transform-v2
> > }
> >
> > sink {
> > Console {
> > parallelism = 3
> > }
> >
> > # If you would like to get more information about how to configure seatunnel and see full list of sink plugins,
> > # please go to https://seatunnel.apache.org/docs/category/sink-v2
> > }
> > ```
> >
> >
> > #### TestFlinkParameter
> >  
> > #### org.apache.seatunnel.example.flink.v2.SeaTunnelApiExample
> >  PTAL: @TyrantLucifer @ruanwenjun @EricJoy2048 I added some screenshots to demonstrate this
>
> I think you should ensure the parameters injected in real flink jobs, not only codes. You should submit a seatunnel on flink engine and make a snapshot to verify it worked.
I provide some screenshots of the flink run web Ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 closed pull request #5480: [feature][flink][job][conf] Add external configuration parameters
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 closed pull request #5480: [feature][flink][job][conf] Add external configuration parameters
URL: https://github.com/apache/seatunnel/pull/5480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Flink] Add external configuration parameters [seatunnel]
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #5480:
URL: https://github.com/apache/seatunnel/pull/5480#issuecomment-1778425390
@TyrantLucifer Could you take a look again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Flink] Add external configuration parameters [seatunnel]
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on PR #5480:
URL: https://github.com/apache/seatunnel/pull/5480#issuecomment-1778470599
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 closed pull request #5480: [feature][flink][job][conf] Add external configuration parameters
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 closed pull request #5480: [feature][flink][job][conf] Add external configuration parameters
URL: https://github.com/apache/seatunnel/pull/5480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] ruanwenjun commented on pull request #5480: [feature][flink][job][conf] Add external configuration parameters
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on PR #5480:
URL: https://github.com/apache/seatunnel/pull/5480#issuecomment-1718815331
LGTM, please add doc about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 commented on pull request #5480: [feature][flink][job][conf] Add external configuration parameters
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 commented on PR #5480:
URL: https://github.com/apache/seatunnel/pull/5480#issuecomment-1718937425
There is a problem with some parameter configuration. I am working on it. Do not merge it
@ruanwenjun @TyrantLucifer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 commented on pull request #5480: [feature][flink][job][conf] Add external configuration parameters
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 commented on PR #5480:
URL: https://github.com/apache/seatunnel/pull/5480#issuecomment-1720765761
PTAL: @TyrantLucifer @ruanwenjun I added some CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 commented on pull request #5480: [feature][flink][job][conf] Add external configuration parameters
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 commented on PR #5480:
URL: https://github.com/apache/seatunnel/pull/5480#issuecomment-1722476608
#### conf file
```
env {
# You can set flink configuration here
execution.parallelism = 2
job.mode = "STREAMING"
flink.execution.checkpointing.interval = 5000
flink.execution.checkpointing.unaligned.enabled = true
flink.execution.checkpointing.aligned-checkpoint-timeout = 100000
flink.jobstore.cache-size = 52428801
flink.state.backend.rocksdb.predefined-options = SPINNING_DISK_OPTIMIZED_HIGH_MEM
}
source {
# This is a example source plugin **only for test and demonstrate the feature source plugin**
FakeSource {
parallelism = 2
result_table_name = "fake"
row.num = 16
schema = {
fields {
name = "string"
age = "int"
}
}
}
# If you would like to get more information about how to configure seatunnel and see full list of source plugins,
# please go to https://seatunnel.apache.org/docs/category/source-v2
}
transform {
# If you would like to get more information about how to configure seatunnel and see full list of transform plugins,
# please go to https://seatunnel.apache.org/docs/category/transform-v2
}
sink {
Console {
parallelism = 3
}
# If you would like to get more information about how to configure seatunnel and see full list of sink plugins,
# please go to https://seatunnel.apache.org/docs/category/sink-v2
}
```
#### TestFlinkParameter
#### org.apache.seatunnel.example.flink.v2.SeaTunnelApiExample
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 closed pull request #5480: [Feature][Flink] Add external configuration parameters
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 closed pull request #5480: [Feature][Flink] Add external configuration parameters
URL: https://github.com/apache/seatunnel/pull/5480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] TyrantLucifer commented on pull request #5480: [feature][flink][job][conf] Add external configuration parameters
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on PR #5480:
URL: https://github.com/apache/seatunnel/pull/5480#issuecomment-1722393569
> PTAL: @TyrantLucifer @ruanwenjun I added some CI
>
>
Overall LGTM, but the test case that you added I didn't any way to see the parameter worded really. Could you please compiled the project and try verify it in a local flink env and offer the screen shots for it？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 closed pull request #5480: [feature][flink][job][conf] Add external configuration parameters
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 closed pull request #5480: [feature][flink][job][conf] Add external configuration parameters
URL: https://github.com/apache/seatunnel/pull/5480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Flink] Add external configuration parameters [seatunnel]
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 commented on PR #5480:
URL: https://github.com/apache/seatunnel/pull/5480#issuecomment-1778413537
PTAL: @Hisoka-X
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 closed pull request #5480: [feature][flink][job][conf] Add external configuration parameters
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 closed pull request #5480: [feature][flink][job][conf] Add external configuration parameters
URL: https://github.com/apache/seatunnel/pull/5480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] TyrantLucifer commented on pull request #5480: [feature][flink][job][conf] Add external configuration parameters
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on PR #5480:
URL: https://github.com/apache/seatunnel/pull/5480#issuecomment-1718940173
> There is a problem with some parameter configuration. I am working on it. Do not merge it @ruanwenjun @TyrantLucifer
Waiting CI/CD and offer some screenshots to verify it worked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 closed pull request #5480: [feature][flink][job][conf] Add external configuration parameters
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 closed pull request #5480: [feature][flink][job][conf] Add external configuration parameters
URL: https://github.com/apache/seatunnel/pull/5480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 closed pull request #5480: [feature][flink][job][conf] Add external configuration parameters
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 closed pull request #5480: [feature][flink][job][conf] Add external configuration parameters
URL: https://github.com/apache/seatunnel/pull/5480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 closed pull request #5480: [feature][flink][job][conf] Add external configuration parameters
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 closed pull request #5480: [feature][flink][job][conf] Add external configuration parameters
URL: https://github.com/apache/seatunnel/pull/5480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 closed pull request #5480: [feature][flink][job][conf] Add external configuration parameters
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 closed pull request #5480: [feature][flink][job][conf] Add external configuration parameters
URL: https://github.com/apache/seatunnel/pull/5480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 closed pull request #5480: [feature][flink][job][conf] Add external configuration parameters
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 closed pull request #5480: [feature][flink][job][conf] Add external configuration parameters
URL: https://github.com/apache/seatunnel/pull/5480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Flink] Add external configuration parameters [seatunnel]
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on PR #5480:
URL: https://github.com/apache/seatunnel/pull/5480#issuecomment-1765806813
> #### conf file
> ```
> env {
> # You can set flink configuration here
> execution.parallelism = 2
> job.mode = "STREAMING"
> flink.execution.checkpointing.interval = 5000
> flink.execution.checkpointing.unaligned.enabled = true
> flink.execution.checkpointing.aligned-checkpoint-timeout = 100000
> flink.jobstore.cache-size = 52428801
> flink.state.backend.rocksdb.predefined-options = SPINNING_DISK_OPTIMIZED_HIGH_MEM
> }
>
> source {
> # This is a example source plugin **only for test and demonstrate the feature source plugin**
> FakeSource {
> parallelism = 2
> result_table_name = "fake"
> row.num = 16
> schema = {
> fields {
> name = "string"
> age = "int"
> }
> }
> }
>
> # If you would like to get more information about how to configure seatunnel and see full list of source plugins,
> # please go to https://seatunnel.apache.org/docs/category/source-v2
> }
>
> transform {
>
> # If you would like to get more information about how to configure seatunnel and see full list of transform plugins,
> # please go to https://seatunnel.apache.org/docs/category/transform-v2
> }
>
> sink {
> Console {
> parallelism = 3
> }
>
> # If you would like to get more information about how to configure seatunnel and see full list of sink plugins,
> # please go to https://seatunnel.apache.org/docs/category/sink-v2
> }
> ```
>
> #### TestFlinkParameter
>  
>
> #### org.apache.seatunnel.example.flink.v2.SeaTunnelApiExample
>  PTAL: @TyrantLucifer @ruanwenjun @EricJoy2048 I added some screenshots to demonstrate this
I think you should ensure the parameters injected in real flink jobs, not only codes. You should submit a seatunnel on flink engine and make a snapshot to verify it worked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Flink] Add external configuration parameters [seatunnel]
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X merged PR #5480:
URL: https://github.com/apache/seatunnel/pull/5480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org