You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/02/15 15:47:26 UTC
[GitHub] [dubbo-go] kzhan opened a new pull request #1052: fix:nacos service provider does not require subscribe
kzhan opened a new pull request #1052:
URL: https://github.com/apache/dubbo-go/pull/1052
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #1052: fix:nacos service provider does not require subscribe
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1052:
URL: https://github.com/apache/dubbo-go/pull/1052#issuecomment-779312997
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1052?src=pr&el=h1) Report
> Merging [#1052](https://codecov.io/gh/apache/dubbo-go/pull/1052?src=pr&el=desc) (3d2479f) into [master](https://codecov.io/gh/apache/dubbo-go/commit/c3b3b56b439222d1adcff4161f105a8851e78a24?el=desc) (c3b3b56) will **decrease** coverage by `0.10%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1052?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1052 +/- ##
==========================================
- Coverage 59.74% 59.63% -0.11%
==========================================
Files 261 261
Lines 12923 12926 +3
==========================================
- Hits 7721 7709 -12
- Misses 4228 4245 +17
+ Partials 974 972 -2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1052?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1052/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `49.28% <0.00%> (-1.08%)` | :arrow_down: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/1052/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `28.00% <0.00%> (-9.61%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1052?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1052?src=pr&el=footer). Last update [c3b3b56...3d2479f](https://codecov.io/gh/apache/dubbo-go/pull/1052?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] kzhan closed pull request #1052: fix:nacos service provider does not require subscribe
Posted by GitBox <gi...@apache.org>.
kzhan closed pull request #1052:
URL: https://github.com/apache/dubbo-go/pull/1052
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org