You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/01 20:28:16 UTC

[GitHub] [kafka] gharris1727 commented on pull request #8259: KAFKA-7421: Ensure Connect's PluginClassLoader is truly parallel capable and resolve deadlock occurrences

gharris1727 commented on pull request #8259:
URL: https://github.com/apache/kafka/pull/8259#issuecomment-788250316


   Now that the bug is fixed, some comments are explicitly incorrect. For example:
   ```
           // 1. Lock the PluginClassLoader (via PluginClassLoader::loadClass)
           // This behavior is specific to the JVM, not the classloader implementation
   ```
   And a lot have the wrong intent, or are misleading. Do you think we should fix some or all of these, or leave them as a detailed description of how the bug _did_ happen when it existed?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org