You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mina.apache.org by lg...@apache.org on 2017/10/01 16:32:51 UTC
mina-sshd git commit: Fixed some Javadoc issues
Repository: mina-sshd
Updated Branches:
refs/heads/master a5c23a552 -> 9a063f5ea
Fixed some Javadoc issues
Project: http://git-wip-us.apache.org/repos/asf/mina-sshd/repo
Commit: http://git-wip-us.apache.org/repos/asf/mina-sshd/commit/9a063f5e
Tree: http://git-wip-us.apache.org/repos/asf/mina-sshd/tree/9a063f5e
Diff: http://git-wip-us.apache.org/repos/asf/mina-sshd/diff/9a063f5e
Branch: refs/heads/master
Commit: 9a063f5ea96defa7c76b3d068007b08ec6ca8a53
Parents: a5c23a5
Author: Lyor Goldstein <ly...@gmail.com>
Authored: Sun Oct 1 19:33:56 2017 +0300
Committer: Lyor Goldstein <ly...@gmail.com>
Committed: Sun Oct 1 19:33:56 2017 +0300
----------------------------------------------------------------------
.../config/keys/loader/putty/AbstractPuttyKeyDecoder.java | 2 ++
.../config/keys/loader/putty/PuttyKeyPairResourceParser.java | 2 ++
.../config/keys/impl/AbstractIdentityResourceLoader.java | 4 ++--
.../java/org/apache/sshd/common/util/io/der/DERWriter.java | 8 ++++++++
4 files changed, 14 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mina-sshd/blob/9a063f5e/sshd-contrib/src/main/java/org/apache/sshd/common/config/keys/loader/putty/AbstractPuttyKeyDecoder.java
----------------------------------------------------------------------
diff --git a/sshd-contrib/src/main/java/org/apache/sshd/common/config/keys/loader/putty/AbstractPuttyKeyDecoder.java b/sshd-contrib/src/main/java/org/apache/sshd/common/config/keys/loader/putty/AbstractPuttyKeyDecoder.java
index 101119b..d2428e2 100644
--- a/sshd-contrib/src/main/java/org/apache/sshd/common/config/keys/loader/putty/AbstractPuttyKeyDecoder.java
+++ b/sshd-contrib/src/main/java/org/apache/sshd/common/config/keys/loader/putty/AbstractPuttyKeyDecoder.java
@@ -40,6 +40,8 @@ import org.apache.sshd.common.util.GenericUtils;
import org.apache.sshd.common.util.ValidateUtils;
/**
+ * @param <PUB> Generic public key type
+ * @param <PRV> Generic private key type
* @author <a href="mailto:dev@mina.apache.org">Apache MINA SSHD Project</a>
*/
public abstract class AbstractPuttyKeyDecoder<PUB extends PublicKey, PRV extends PrivateKey>
http://git-wip-us.apache.org/repos/asf/mina-sshd/blob/9a063f5e/sshd-contrib/src/main/java/org/apache/sshd/common/config/keys/loader/putty/PuttyKeyPairResourceParser.java
----------------------------------------------------------------------
diff --git a/sshd-contrib/src/main/java/org/apache/sshd/common/config/keys/loader/putty/PuttyKeyPairResourceParser.java b/sshd-contrib/src/main/java/org/apache/sshd/common/config/keys/loader/putty/PuttyKeyPairResourceParser.java
index a1e795b..06443d9 100644
--- a/sshd-contrib/src/main/java/org/apache/sshd/common/config/keys/loader/putty/PuttyKeyPairResourceParser.java
+++ b/sshd-contrib/src/main/java/org/apache/sshd/common/config/keys/loader/putty/PuttyKeyPairResourceParser.java
@@ -87,6 +87,8 @@ import org.apache.sshd.common.util.security.SecurityUtils;
* Emdk
* Private-MAC: 50c45751d18d74c00fca395deb7b7695e3ed6f77
* </PRE>
+ * @param <PUB> Generic public key type
+ * @param <PRV> Generic private key type
* @author <a href="mailto:dev@mina.apache.org">Apache MINA SSHD Project</a>
*/
//CHECKSTYLE:ON
http://git-wip-us.apache.org/repos/asf/mina-sshd/blob/9a063f5e/sshd-core/src/main/java/org/apache/sshd/common/config/keys/impl/AbstractIdentityResourceLoader.java
----------------------------------------------------------------------
diff --git a/sshd-core/src/main/java/org/apache/sshd/common/config/keys/impl/AbstractIdentityResourceLoader.java b/sshd-core/src/main/java/org/apache/sshd/common/config/keys/impl/AbstractIdentityResourceLoader.java
index fbe8d71..a2412bd 100644
--- a/sshd-core/src/main/java/org/apache/sshd/common/config/keys/impl/AbstractIdentityResourceLoader.java
+++ b/sshd-core/src/main/java/org/apache/sshd/common/config/keys/impl/AbstractIdentityResourceLoader.java
@@ -28,8 +28,8 @@ import org.apache.sshd.common.util.ValidateUtils;
import org.apache.sshd.common.util.logging.AbstractLoggingBean;
/**
- * TODO Add javadoc
- *
+ * @param <PUB> Generic public key type
+ * @param <PRV> Generic private key type
* @author <a href="mailto:dev@mina.apache.org">Apache MINA SSHD Project</a>
*/
public abstract class AbstractIdentityResourceLoader<PUB extends PublicKey, PRV extends PrivateKey>
http://git-wip-us.apache.org/repos/asf/mina-sshd/blob/9a063f5e/sshd-core/src/main/java/org/apache/sshd/common/util/io/der/DERWriter.java
----------------------------------------------------------------------
diff --git a/sshd-core/src/main/java/org/apache/sshd/common/util/io/der/DERWriter.java b/sshd-core/src/main/java/org/apache/sshd/common/util/io/der/DERWriter.java
index 2d55bfd..a001e0e 100644
--- a/sshd-core/src/main/java/org/apache/sshd/common/util/io/der/DERWriter.java
+++ b/sshd-core/src/main/java/org/apache/sshd/common/util/io/der/DERWriter.java
@@ -78,6 +78,9 @@ public class DERWriter extends FilterOutputStream {
/**
* The integer is always considered to be positive, so if the first byte is < 0,
* we pad with a zero to make it positive
+ *
+ * @param bytes {@link BigInteger} bytes
+ * @throws IOException If failed to write the bytes
*/
public void writeBigInteger(byte... bytes) throws IOException {
writeBigInteger(bytes, 0, NumberUtils.length(bytes));
@@ -86,6 +89,11 @@ public class DERWriter extends FilterOutputStream {
/**
* The integer is always considered to be positive, so if the first byte is < 0,
* we pad with a zero to make it positive
+ *
+ * @param bytes {@link BigInteger} bytes
+ * @param off Offset in bytes data
+ * @param len Number of bytes to write
+ * @throws IOException If failed to write the bytes
*/
public void writeBigInteger(byte[] bytes, int off, int len) throws IOException {
// Strip leading zeroes