[GitHub] [hadoop] surajj-naik commented on a change in pull request #2564: YARN-10538: Add RECOMMISSIONING nodes to the list of updated nodes returned to the AM

[GitBox <gi...@apache.org>]

surajj-naik commented on a change in pull request #2564:
URL: https://github.com/apache/hadoop/pull/2564#discussion_r546761268



##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
##########
@@ -1325,6 +1325,10 @@ public void transition(RMNodeImpl rmNode, RMNodeEvent event) {
           .handle(
               new NodeResourceUpdateSchedulerEvent(rmNode, ResourceOption
                   .newInstance(rmNode.totalCapability, 0)));
+

Review comment:
       Cosmetic:
   Can you add a comment maybe suggesting that you're marking recommissioning nodes as usable or maybe even why you're marking them as usable. Just a thought.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org