You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@avro.apache.org by ha...@apache.org on 2010/06/01 18:21:31 UTC
svn commit: r950144 - in /avro/branches/branch-1.3: CHANGES.txt
lang/py/test/sample_http_client.py
Author: hammer
Date: Tue Jun 1 16:21:31 2010
New Revision: 950144
URL: http://svn.apache.org/viewvc?rev=950144&view=rev
Log:
AVRO-496. python sample_http_client.py is broken (Jeff Hodges via hammer)
Modified:
avro/branches/branch-1.3/CHANGES.txt
avro/branches/branch-1.3/lang/py/test/sample_http_client.py
Modified: avro/branches/branch-1.3/CHANGES.txt
URL: http://svn.apache.org/viewvc/avro/branches/branch-1.3/CHANGES.txt?rev=950144&r1=950143&r2=950144&view=diff
==============================================================================
--- avro/branches/branch-1.3/CHANGES.txt (original)
+++ avro/branches/branch-1.3/CHANGES.txt Tue Jun 1 16:21:31 2010
@@ -1,6 +1,8 @@
Avro Change Log
Avro 1.3.3 (Unreleased)
+ BUG FIXES
+ AVRO-496. python sample_http_client.py is broken (Jeff Hodges via hammer)
Avro 1.3.2 (31 March 2010)
Modified: avro/branches/branch-1.3/lang/py/test/sample_http_client.py
URL: http://svn.apache.org/viewvc/avro/branches/branch-1.3/lang/py/test/sample_http_client.py?rev=950144&r1=950143&r2=950144&view=diff
==============================================================================
--- avro/branches/branch-1.3/lang/py/test/sample_http_client.py (original)
+++ avro/branches/branch-1.3/lang/py/test/sample_http_client.py Tue Jun 1 16:21:31 2010
@@ -59,9 +59,7 @@ class UsageError(Exception):
return repr(self.value)
def make_requestor(server_host, server_port, protocol):
- conn = httplib.HTTPConnection(SERVER_HOST, SERVER_PORT)
- conn.connect()
- client = ipc.HTTPTransceiver(conn)
+ client = ipc.HTTPTransceiver(SERVER_HOST, SERVER_PORT)
return ipc.Requestor(protocol, client)
if __name__ == '__main__':
Re: svn commit: r950144 - in /avro/branches/branch-1.3: CHANGES.txt
lang/py/test/sample_http_client.py
Posted by Jeff Hammerbacher <ha...@cloudera.com>.
FWIW, I think we have exposed my experiences with using a data warehouse for
so many years. Bypassing the transaction engine with a bulk load instead of
using a long-running transaction for mass edits is in my blood...
On Tue, Jun 1, 2010 at 11:06 AM, Jeff Hammerbacher <ha...@cloudera.com>wrote:
> So, rather than maintaining this incrementally, you want to move all of
>> these en-masse? That's fine with me, if you want to take on keeping this
>> straight. To my thinking, it's simpler to maintain this as we go.
>>
>
> Should be a simple copy-paste from the CHANGES.txt in branch-1.3, no?
>
Re: svn commit: r950144 - in /avro/branches/branch-1.3: CHANGES.txt
lang/py/test/sample_http_client.py
Posted by Bruce Mitchener <br...@gmail.com>.
Nothing on the C side. My changes are still in-progress and are API breaking
in major ways (and more API changes coming before we're ready for 1.4).
I've no idea about the C++ side.
- Bruce
On Fri, Jun 4, 2010 at 9:58 PM, Jeff Hammerbacher <ha...@cloudera.com>wrote:
> Thanks! C or C++ folks? I might try my hand at the merge this morning,
> since
> there are only three total patches there, but I'd prefer if you guys chimed
> in. I'm cutting the release at noon.
>
> On Thu, Jun 3, 2010 at 10:40 PM, Jeff Hodges <jh...@twitter.com> wrote:
>
> > Ruby side is merged into branch-1.3.
> > --
> > Jeff
> >
> > On Tue, Jun 1, 2010 at 11:13 AM, Doug Cutting <cu...@apache.org>
> wrote:
> > > On 06/01/2010 11:06 AM, Jeff Hammerbacher wrote:
> > >>>
> > >>> So, rather than maintaining this incrementally, you want to move all
> of
> > >>> these en-masse? That's fine with me, if you want to take on keeping
> > this
> > >>> straight. To my thinking, it's simpler to maintain this as we go.
> > >>
> > >> Should be a simple copy-paste from the CHANGES.txt in branch-1.3, no?
> > >
> > > You'll have to also then find each message that was pasted and remove
> it
> > > from the 1.4.0 section. Not a big deal.
> > >
> > > Another reason to update-as-we-go is to better track of what's been
> > merged
> > > and what's not. If the CHANGES.txt in trunk and the branch disagree
> then
> > > folks have to know which takes precedence.
> > >
> > > Doug
> > >
> >
>
Re: svn commit: r950144 - in /avro/branches/branch-1.3: CHANGES.txt
lang/py/test/sample_http_client.py
Posted by Jeff Hammerbacher <ha...@cloudera.com>.
Thanks! C or C++ folks? I might try my hand at the merge this morning, since
there are only three total patches there, but I'd prefer if you guys chimed
in. I'm cutting the release at noon.
On Thu, Jun 3, 2010 at 10:40 PM, Jeff Hodges <jh...@twitter.com> wrote:
> Ruby side is merged into branch-1.3.
> --
> Jeff
>
> On Tue, Jun 1, 2010 at 11:13 AM, Doug Cutting <cu...@apache.org> wrote:
> > On 06/01/2010 11:06 AM, Jeff Hammerbacher wrote:
> >>>
> >>> So, rather than maintaining this incrementally, you want to move all of
> >>> these en-masse? That's fine with me, if you want to take on keeping
> this
> >>> straight. To my thinking, it's simpler to maintain this as we go.
> >>
> >> Should be a simple copy-paste from the CHANGES.txt in branch-1.3, no?
> >
> > You'll have to also then find each message that was pasted and remove it
> > from the 1.4.0 section. Not a big deal.
> >
> > Another reason to update-as-we-go is to better track of what's been
> merged
> > and what's not. If the CHANGES.txt in trunk and the branch disagree then
> > folks have to know which takes precedence.
> >
> > Doug
> >
>
Re: svn commit: r950144 - in /avro/branches/branch-1.3: CHANGES.txt
lang/py/test/sample_http_client.py
Posted by Jeff Hodges <jh...@twitter.com>.
Ruby side is merged into branch-1.3.
--
Jeff
On Tue, Jun 1, 2010 at 11:13 AM, Doug Cutting <cu...@apache.org> wrote:
> On 06/01/2010 11:06 AM, Jeff Hammerbacher wrote:
>>>
>>> So, rather than maintaining this incrementally, you want to move all of
>>> these en-masse? That's fine with me, if you want to take on keeping this
>>> straight. To my thinking, it's simpler to maintain this as we go.
>>
>> Should be a simple copy-paste from the CHANGES.txt in branch-1.3, no?
>
> You'll have to also then find each message that was pasted and remove it
> from the 1.4.0 section. Not a big deal.
>
> Another reason to update-as-we-go is to better track of what's been merged
> and what's not. If the CHANGES.txt in trunk and the branch disagree then
> folks have to know which takes precedence.
>
> Doug
>
Re: svn commit: r950144 - in /avro/branches/branch-1.3: CHANGES.txt
lang/py/test/sample_http_client.py
Posted by Doug Cutting <cu...@apache.org>.
On 06/01/2010 11:06 AM, Jeff Hammerbacher wrote:
>> So, rather than maintaining this incrementally, you want to move all of
>> these en-masse? That's fine with me, if you want to take on keeping this
>> straight. To my thinking, it's simpler to maintain this as we go.
>
> Should be a simple copy-paste from the CHANGES.txt in branch-1.3, no?
You'll have to also then find each message that was pasted and remove it
from the 1.4.0 section. Not a big deal.
Another reason to update-as-we-go is to better track of what's been
merged and what's not. If the CHANGES.txt in trunk and the branch
disagree then folks have to know which takes precedence.
Doug
Re: svn commit: r950144 - in /avro/branches/branch-1.3: CHANGES.txt
lang/py/test/sample_http_client.py
Posted by Jeff Hammerbacher <ha...@cloudera.com>.
>
> So, rather than maintaining this incrementally, you want to move all of
> these en-masse? That's fine with me, if you want to take on keeping this
> straight. To my thinking, it's simpler to maintain this as we go.
>
Should be a simple copy-paste from the CHANGES.txt in branch-1.3, no?
Re: svn commit: r950144 - in /avro/branches/branch-1.3: CHANGES.txt
lang/py/test/sample_http_client.py
Posted by Doug Cutting <cu...@apache.org>.
On 06/01/2010 10:46 AM, Jeff Hammerbacher wrote:
>> Also, you should update trunk's CHANGES.txt so that these changes show up in
>> the 1.3.3 section there and no longer in the 1.4.0 section.
>
> Going to update it when we actually have a release.
So, rather than maintaining this incrementally, you want to move all of
these en-masse? That's fine with me, if you want to take on keeping
this straight. To my thinking, it's simpler to maintain this as we go.
Doug
Re: svn commit: r950144 - in /avro/branches/branch-1.3: CHANGES.txt
lang/py/test/sample_http_client.py
Posted by Jeff Hammerbacher <ha...@cloudera.com>.
>
> When merging something from trunk you should indicate that in the commit
> message. The commit message format used in Hadoop is, "Merge rXXX from
> trunk to branch-1.3. Fixes AVRO-YYY."
>
Yeah saw that on the HowToRelease wiki page after merging.
> Are you using 'svn merge' for these? Since subversion 1.5 that should keep
> track of revisions done with 'svn merge', perhaps obviating the need to
> mention them in the commit message, but I see no 'svn mergeinfo' for the 1.3
> branch, so I'm guessing you're not.
>
Yep, using svn merge -c <revision number> <path_to_avro_trunk>
Also, you should update trunk's CHANGES.txt so that these changes show up in
> the 1.3.3 section there and no longer in the 1.4.0 section.
Going to update it when we actually have a release.
Re: svn commit: r950144 - in /avro/branches/branch-1.3: CHANGES.txt
lang/py/test/sample_http_client.py
Posted by Doug Cutting <cu...@apache.org>.
On 06/01/2010 09:21 AM, hammer@apache.org wrote:
> AVRO-496. python sample_http_client.py is broken (Jeff Hodges via hammer)
>
>
> Modified:
> avro/branches/branch-1.3/CHANGES.txt
> avro/branches/branch-1.3/lang/py/test/sample_http_client.py
When merging something from trunk you should indicate that in the commit
message. The commit message format used in Hadoop is, "Merge rXXX from
trunk to branch-1.3. Fixes AVRO-YYY."
Are you using 'svn merge' for these? Since subversion 1.5 that should
keep track of revisions done with 'svn merge', perhaps obviating the
need to mention them in the commit message, but I see no 'svn mergeinfo'
for the 1.3 branch, so I'm guessing you're not.
Also, you should update trunk's CHANGES.txt so that these changes show
up in the 1.3.3 section there and no longer in the 1.4.0 section.
Doug