You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by "nodece (via GitHub)" <gi...@apache.org> on 2023/07/21 07:02:17 UTC

[GitHub] [pulsar] nodece commented on pull request #20848: [fix][broker] Fix the built-in admin failed to delete a topic with a custom authz provider

nodece commented on PR #20848:
URL: https://github.com/apache/pulsar/pull/20848#issuecomment-1645079336

   > It's also very confusing to see the methods added in https://github.com/apache/pulsar/pull/20496 don't accept any role argument.
   
   I agree with you. IMO, we suggest adding `String role` and `AuthenticationDataSource authData` to these new methods first and fixing the return value.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org