You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by "DaanHoogland (via GitHub)" <gi...@apache.org> on 2026/10/22 13:56:41 UTC

[PR] use ConfigKeys for UCS settings and remaining getValue() literals [cloudstack]

DaanHoogland opened a new pull request, #14472:
URL: https://github.com/apache/cloudstack/pull/14472

   ### Description
   
   Switches the UCS settings and the remaining string-literal `ConfigurationDao.getValue("...")` lookups to `ConfigKey`s.
   
   Part 6 of 12 of the split of #13884 (phase out the deprecated `Config` enum, #10752). Base: `ghi10752-config-foundation`. Independent of the other PRs based on the foundation, so it can be reviewed and merged in any order relative to them; GitHub retargets it to `main` once the foundation is merged.
   
   Size: 17 files, +195/-60.
   
   Split overview: foundation → parallel PRs (account, vpn-vpc, snapshot-usage, event-bus, literals) + stacked core-1 … core-5 → enum-removal (last).
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [x] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] Build/CI
   - [ ] Test (unit or integration test code)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [x] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [x] Trivial
   
   ### Screenshots (if appropriate):
   
   ### How Has This Been Tested?
   
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   
   #### How did you try to break this feature and the system with this change?
   
   <!-- see how your change affects other areas of the code, etc. -->
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   
   
   
   Local verification: full reactor build (checkstyle included) and the unit tests of every touched module pass on this branch; merging all PRs of the split in any order gives no conflicts and reproduces #13884 plus its fixes.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] use ConfigKeys for UCS settings and remaining getValue() literals [cloudstack]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.

codecov[bot] commented on PR #14472:
URL: https://github.com/apache/cloudstack/pull/14472#issuecomment-6342785390

   ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/14472?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 3.70%. Comparing base ([`d58e94b`](https://app.codecov.io/gh/apache/cloudstack/commit/d58e94ba04dea7c0d05bfc0753ac7316531326a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`60908ad`](https://app.codecov.io/gh/apache/cloudstack/commit/60908ad19725f5a0fb9a9c826438b9e084bf4f21?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@                     Coverage Diff                     @@
   ##           ghi10752-config-foundation   #14472   +/-   ##
   ===========================================================
     Coverage                        3.70%    3.70%           
   ===========================================================
     Files                             493      493           
     Lines                           42558    42558           
     Branches                         8063     8063           
   ===========================================================
     Hits                             1578     1578           
     Misses                          40751    40751           
     Partials                          229      229           
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/14472/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/14472/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.70% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/cloudstack/pull/14472?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] use ConfigKeys for UCS settings and remaining getValue() literals [cloudstack]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #14472:
URL: https://github.com/apache/cloudstack/pull/14472#issuecomment-6367103940

   <!-- coverage-grade-bot -->
   ## 🔴 Test Coverage Grade: `D` — Marginal
   
   | Metric | Value |
   |--------|-------|
   | Line coverage   | **25.55%** |
   | Branch coverage | **19.82%** |
   
   ### Grade Scale
   | Grade | Line Coverage | Meaning |
   |-------|--------------|---------|
   | 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
   | 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
   | 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
   | 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
   | ⛔ F | < 20%  | Failing - tests? what tests? 🔥 |
   
   > Branch coverage is shown as a secondary signal. Grade is determined by **line coverage**.
   > [View full Actions run](https://github.com/apache/cloudstack/actions/runs/39958352814)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] use ConfigKeys for UCS settings and remaining getValue() literals [cloudstack]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #14472:
URL: https://github.com/apache/cloudstack/pull/14472#issuecomment-6441047410

   This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] use ConfigKeys for UCS settings and remaining getValue() literals [cloudstack]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.

sonarqubecloud[bot] commented on PR #14472:
URL: https://github.com/apache/cloudstack/pull/14472#issuecomment-6464972588

   ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=14472) **Quality Gate failed**  
   Failed conditions  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [4.8% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=14472&metric=new_coverage&view=list) (required ≥ 40%)  
     
   <!-- sqra:qg_revision=ba4efe43f2f7007d3acd7d02ad5a8efe0e5fe5798038b47789094480bf62e1d0 -->
   <!-- sqra-placement-anchor -->
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=14472)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] use ConfigKeys for UCS settings and remaining getValue() literals [cloudstack]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.

sonarqubecloud[bot] commented on PR #14472:
URL: https://github.com/apache/cloudstack/pull/14472#issuecomment-6367095722

   ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=14472) **Quality Gate failed**  
   Failed conditions  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [4.8% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=14472&metric=new_coverage&view=list) (required ≥ 40%)  
     
   <!-- sqra:qg_revision=ba4efe43f2f7007d3acd7d02ad5a8efe0e5fe5798038b47789094480bf62e1d0 -->
   <!-- sqra-placement-anchor -->
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=14472)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] use ConfigKeys for UCS settings and remaining getValue() literals [cloudstack]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.

sonarqubecloud[bot] commented on PR #14472:
URL: https://github.com/apache/cloudstack/pull/14472#issuecomment-6450024608

   ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=14472) **Quality Gate failed**  
   Failed conditions  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [4.8% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=14472&metric=new_coverage&view=list) (required ≥ 40%)  
     
   <!-- sqra:qg_revision=ba4efe43f2f7007d3acd7d02ad5a8efe0e5fe5798038b47789094480bf62e1d0 -->
   <!-- sqra-placement-anchor -->
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=14472)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org