You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "helifu (Code Review)" <ge...@cloudera.org> on 2019/07/24 11:38:34 UTC
[kudu-CR] [master] Change the timeout threshold for unit test case
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13909
Change subject: [master] Change the timeout threshold for unit test case
......................................................................
[master] Change the timeout threshold for unit test case
In the previous patch, we use KUDU_ALLOW_SLOW_TEST to avoid failure
in some environments. Now, another solution is proposed. It changes
the timeout threshold to meet the assertion conditions.
Change-Id: Ief5ec23c83022c2c5dbcc65a110ad8fe1f91f1a7
---
M src/kudu/master/sentry_authz_provider-test.cc
1 file changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/13909/1
--
To view, visit http://gerrit.cloudera.org:8080/13909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief5ec23c83022c2c5dbcc65a110ad8fe1f91f1a7
Gerrit-Change-Number: 13909
Gerrit-PatchSet: 1
Gerrit-Owner: helifu <hz...@corp.netease.com>
[kudu-CR] [master] Change the timeout threshold for unit test case
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13909 )
Change subject: [master] Change the timeout threshold for unit test case
......................................................................
[master] Change the timeout threshold for unit test case
In the previous patch, we use KUDU_ALLOW_SLOW_TEST to avoid failure
in some environments. Now, another solution is proposed. It changes
the timeout threshold to meet the assertion conditions.
Change-Id: Ief5ec23c83022c2c5dbcc65a110ad8fe1f91f1a7
Reviewed-on: http://gerrit.cloudera.org:8080/13909
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/master/sentry_authz_provider-test.cc
1 file changed, 6 insertions(+), 4 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief5ec23c83022c2c5dbcc65a110ad8fe1f91f1a7
Gerrit-Change-Number: 13909
Gerrit-PatchSet: 2
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [master] Change the timeout threshold for unit test case
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13909 )
Change subject: [master] Change the timeout threshold for unit test case
......................................................................
Patch Set 1:
I actually haven't been able to reproduce the reported test failure looping the test hundreds of times in various build modes. I trust you've seen the failure rate go down in your environment?
--
To view, visit http://gerrit.cloudera.org:8080/13909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief5ec23c83022c2c5dbcc65a110ad8fe1f91f1a7
Gerrit-Change-Number: 13909
Gerrit-PatchSet: 1
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 24 Jul 2019 21:58:15 +0000
Gerrit-HasComments: No
[kudu-CR] [master] Change the timeout threshold for unit test case
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13909 )
Change subject: [master] Change the timeout threshold for unit test case
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief5ec23c83022c2c5dbcc65a110ad8fe1f91f1a7
Gerrit-Change-Number: 13909
Gerrit-PatchSet: 1
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 24 Jul 2019 22:06:37 +0000
Gerrit-HasComments: No
[kudu-CR] [master] Change the timeout threshold for unit test case
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13909 )
Change subject: [master] Change the timeout threshold for unit test case
......................................................................
Patch Set 1:
> I actually haven't been able to reproduce the reported test failure
> looping the test hundreds of times in various build modes. I trust
> you've seen the failure rate go down in your environment?
I haven't seen that in my environment, but I assume that might happen when clock is a bit off or in the process of synchronization. I think you can find the stack trace as it's reported in https://issues.apache.org/jira/browse/KUDU-2882
--
To view, visit http://gerrit.cloudera.org:8080/13909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief5ec23c83022c2c5dbcc65a110ad8fe1f91f1a7
Gerrit-Change-Number: 13909
Gerrit-PatchSet: 1
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 24 Jul 2019 22:06:14 +0000
Gerrit-HasComments: No