You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "Shantanuhatagale13 (via GitHub)" <gi...@apache.org> on 2024/10/15 07:01:08 UTC
[PR] Update cloud-web-ipallocator.py [cloudstack]
Shantanuhatagale13 opened a new pull request, #9796:
URL: https://github.com/apache/cloudstack/pull/9796
Shebang updated for portability.
Exception handling now prints error details.
Used pop(0) for removing the first element from availIP. Added constants for better code management.
Used f-strings for modern string formatting.
File writing in with block for safety.
Improved comments to enhance readability.
### Description
This PR...
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update cloud-web-ipallocator.py [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #9796:
URL: https://github.com/apache/cloudstack/pull/9796#issuecomment-5269482539
Hi @Shantanuhatagale13 can you please address the review comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update cloud-web-ipallocator.py [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #9796:
URL: https://github.com/apache/cloudstack/pull/9796#discussion_r1812619988
##########
python/incubation/cloud-web-ipallocator.py:
##########
@@ -16,144 +16,165 @@
# specific language governing permissions and limitations
# under the License.
-
-
-
-
import web
-import socket, struct
+import socket
+import struct
import cloud_utils
from cloud_utils import Command
+
+# Constants
+DNSMASQ_SERVICE = "dnsmasq"
+DNSMASQ_CONFIG = "/files/etc/dnsmasq.conf"
+RESTART = "restart"
+
+# URL mapping
urls = ("/ipallocator", "ipallocator")
app = web.application(urls, globals())
+# Command wrappers
augtool = Command("augtool")
service = Command("service")
+
class dhcp:
- _instance = None
- def __init__(self):
- self.availIP=[]
- self.router=None
- self.netmask=None
- self.initialized=False
-
- options = augtool.match("/files/etc/dnsmasq.conf/dhcp-option").stdout.decode('utf-8').strip()
- for option in options.splitlines():
- if option.find("option:router") != -1:
- self.router = option.split("=")[1].strip().split(",")[1]
- print(self.router)
-
- dhcp_range = augtool.get("/files/etc/dnsmasq.conf/dhcp-range").stdout.decode('utf-8').strip()
- dhcp_start = dhcp_range.split("=")[1].strip().split(",")[0]
- dhcp_end = dhcp_range.split("=")[1].strip().split(",")[1]
- self.netmask = dhcp_range.split("=")[1].strip().split(",")[2]
- print(dhcp_start, dhcp_end, self.netmask)
-
- start_ip_num = self.ipToNum(dhcp_start);
- end_ip_num = self.ipToNum(dhcp_end)
- print(start_ip_num, end_ip_num)
-
- for ip in range(start_ip_num, end_ip_num + 1):
- self.availIP.append(ip)
- print(self.availIP[0], self.availIP[len(self.availIP) - 1])
-
- #load the ip already allocated
- self.reloadAllocatedIP()
-
- def ipToNum(self, ip):
- return struct.unpack("!I", socket.inet_aton(ip))[0]
-
- def numToIp(self, num):
- return socket.inet_ntoa(struct.pack('!I', num))
-
- def getFreeIP(self):
- if len(self.availIP) > 0:
- ip = self.numToIp(self.availIP[0])
- self.availIP.remove(self.availIP[0])
- return ip
- else:
- return None
-
- def getNetmask(self):
- return self.netmask
-
- def getRouter(self):
- return self.router
-
- def getInstance():
- if not dhcp._instance:
- dhcp._instance = dhcp()
- return dhcp._instance
- getInstance = staticmethod(getInstance)
-
- def reloadAllocatedIP(self):
- dhcp_hosts = augtool.match("/files/etc/dnsmasq.conf/dhcp-host").stdout.decode('utf-8').strip().splitlines()
-
- for host in dhcp_hosts:
- if host.find("dhcp-host") != -1:
- allocatedIP = self.ipToNum(host.split("=")[1].strip().split(",")[1])
- if allocatedIP in self.availIP:
- self.availIP.remove(allocatedIP)
-
- def allocateIP(self, mac):
- newIP = self.getFreeIP()
- dhcp_host = augtool.match("/files/etc/dnsmasq.conf/dhcp-host").stdout.decode('utf-8').strip()
- cnt = len(dhcp_host.splitlines()) + 1
- script = """set %s %s
- save"""%("/files/etc/dnsmasq.conf/dhcp-host[" + str(cnt) + "]", str(mac) + "," + newIP)
- augtool < script
- #reset dnsmasq
- service("dnsmasq", "restart", stdout=None, stderr=None)
- return newIP
-
- def releaseIP(self, ip):
- dhcp_host = augtool.match("/files/etc/dnsmasq.conf/dhcp-host").stdout.decode('utf-8').strip()
- path = None
- for host in dhcp_host.splitlines():
- if host.find(ip) != -1:
- path = host.split("=")[0].strip()
-
- if path == None:
- print("Can't find " + str(ip) + " in conf file")
- return None
-
- print(path)
- script = """rm %s
- save"""%(path)
- augtool < script
-
- self.availIP.remove(ip)
-
- #reset dnsmasq
- service("dnsmasq", "restart", stdout=None, stderr=None)
+ _instance = None
+
+ def __init__(self):
+ self.availIP = []
+ self.router = None
+ self.netmask = None
+ self.initialized = False
+
+ # Load DHCP options
+ options = augtool.match(f"{DNSMASQ_CONFIG}/dhcp-option").stdout.decode('utf-8').strip()
+ for option in options.splitlines():
+ if "option:router" in option:
+ self.router = option.split("=")[1].strip().split(",")[1]
+ print(self.router)
+
+ # Load DHCP range
+ dhcp_range = augtool.get(f"{DNSMASQ_CONFIG}/dhcp-range").stdout.decode('utf-8').strip()
+ dhcp_start = dhcp_range.split("=")[1].strip().split(",")[0]
+ dhcp_end = dhcp_range.split("=")[1].strip().split(",")[1]
+ self.netmask = dhcp_range.split("=")[1].strip().split(",")[2]
+ print(dhcp_start, dhcp_end, self.netmask)
+
+ # Convert IP range to numbers
+ start_ip_num = self.ipToNum(dhcp_start)
+ end_ip_num = self.ipToNum(dhcp_end)
+ print(start_ip_num, end_ip_num)
+
+ # Populate available IPs
+ for ip in range(start_ip_num, end_ip_num + 1):
+ self.availIP.append(ip)
+ print(self.availIP[0], self.availIP[-1])
+
+ # Load already allocated IPs
+ self.reloadAllocatedIP()
+
+ def ipToNum(self, ip):
+ """Convert IP address string to a number."""
+ return struct.unpack("!I", socket.inet_aton(ip))[0]
+
+ def numToIp(self, num):
+ """Convert a number back to an IP address."""
+ return socket.inet_ntoa(struct.pack('!I', num))
+
+ def getFreeIP(self):
+ """Return the next available IP address."""
+ if len(self.availIP) > 0:
+ ip = self.numToIp(self.availIP.pop(0))
+ return ip
+ else:
+ return None
+
+ def getNetmask(self):
+ return self.netmask
+
+ def getRouter(self):
+ return self.router
+
+ @staticmethod
+ def getInstance():
+ if not dhcp._instance:
+ dhcp._instance = dhcp()
+ return dhcp._instance
+
+ def reloadAllocatedIP(self):
+ """Reload already allocated IPs from the config file."""
+ dhcp_hosts = augtool.match(f"{DNSMASQ_CONFIG}/dhcp-host").stdout.decode('utf-8').strip().splitlines()
+ for host in dhcp_hosts:
+ if "dhcp-host" in host:
+ allocatedIP = self.ipToNum(host.split("=")[1].strip().split(",")[1])
+ if allocatedIP in self.availIP:
+ self.availIP.remove(allocatedIP)
+
+ def allocateIP(self, mac):
+ """Allocate an IP address to the given MAC address."""
+ newIP = self.getFreeIP()
+ dhcp_host = augtool.match(f"{DNSMASQ_CONFIG}/dhcp-host").stdout.decode('utf-8').strip()
+ cnt = len(dhcp_host.splitlines()) + 1
+ script = f"""set {DNSMASQ_CONFIG}/dhcp-host[{cnt}] {mac},{newIP}
+ save"""
+ with open("/path/to/script", "w") as script_file:
+ script_file.write(script)
+ augtool < script_file
+
+ # Restart dnsmasq service
+ service(DNSMASQ_SERVICE, RESTART, stdout=None, stderr=None)
+ return newIP
+
+ def releaseIP(self, ip):
+ """Release the given IP address and remove it from the config."""
+ dhcp_host = augtool.match(f"{DNSMASQ_CONFIG}/dhcp-host").stdout.decode('utf-8').strip()
+ path = None
+ for host in dhcp_host.splitlines():
+ if ip in host:
+ path = host.split("=")[0].strip()
+
+ if not path:
+ print(f"Can't find {ip} in conf file")
+ return None
+
+ script = f"rm {path}\n save"
+ with open("/path/to/script", "w") as script_file:
Review Comment:
pretty sure "/path/to/script" is not intended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update cloud-web-ipallocator.py [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #9796:
URL: https://github.com/apache/cloudstack/pull/9796#discussion_r1812611867
##########
python/incubation/cloud-web-ipallocator.py:
##########
@@ -16,144 +16,165 @@
# specific language governing permissions and limitations
# under the License.
-
-
-
-
import web
-import socket, struct
+import socket
+import struct
import cloud_utils
from cloud_utils import Command
+
+# Constants
+DNSMASQ_SERVICE = "dnsmasq"
+DNSMASQ_CONFIG = "/files/etc/dnsmasq.conf"
+RESTART = "restart"
+
+# URL mapping
urls = ("/ipallocator", "ipallocator")
app = web.application(urls, globals())
+# Command wrappers
augtool = Command("augtool")
service = Command("service")
+
class dhcp:
- _instance = None
- def __init__(self):
- self.availIP=[]
- self.router=None
- self.netmask=None
- self.initialized=False
-
- options = augtool.match("/files/etc/dnsmasq.conf/dhcp-option").stdout.decode('utf-8').strip()
- for option in options.splitlines():
- if option.find("option:router") != -1:
- self.router = option.split("=")[1].strip().split(",")[1]
- print(self.router)
-
- dhcp_range = augtool.get("/files/etc/dnsmasq.conf/dhcp-range").stdout.decode('utf-8').strip()
- dhcp_start = dhcp_range.split("=")[1].strip().split(",")[0]
- dhcp_end = dhcp_range.split("=")[1].strip().split(",")[1]
- self.netmask = dhcp_range.split("=")[1].strip().split(",")[2]
- print(dhcp_start, dhcp_end, self.netmask)
-
- start_ip_num = self.ipToNum(dhcp_start);
- end_ip_num = self.ipToNum(dhcp_end)
- print(start_ip_num, end_ip_num)
-
- for ip in range(start_ip_num, end_ip_num + 1):
- self.availIP.append(ip)
- print(self.availIP[0], self.availIP[len(self.availIP) - 1])
-
- #load the ip already allocated
- self.reloadAllocatedIP()
-
- def ipToNum(self, ip):
- return struct.unpack("!I", socket.inet_aton(ip))[0]
-
- def numToIp(self, num):
- return socket.inet_ntoa(struct.pack('!I', num))
-
- def getFreeIP(self):
- if len(self.availIP) > 0:
- ip = self.numToIp(self.availIP[0])
- self.availIP.remove(self.availIP[0])
- return ip
- else:
- return None
-
- def getNetmask(self):
- return self.netmask
-
- def getRouter(self):
- return self.router
-
- def getInstance():
- if not dhcp._instance:
- dhcp._instance = dhcp()
- return dhcp._instance
- getInstance = staticmethod(getInstance)
-
- def reloadAllocatedIP(self):
- dhcp_hosts = augtool.match("/files/etc/dnsmasq.conf/dhcp-host").stdout.decode('utf-8').strip().splitlines()
-
- for host in dhcp_hosts:
- if host.find("dhcp-host") != -1:
- allocatedIP = self.ipToNum(host.split("=")[1].strip().split(",")[1])
- if allocatedIP in self.availIP:
- self.availIP.remove(allocatedIP)
-
- def allocateIP(self, mac):
- newIP = self.getFreeIP()
- dhcp_host = augtool.match("/files/etc/dnsmasq.conf/dhcp-host").stdout.decode('utf-8').strip()
- cnt = len(dhcp_host.splitlines()) + 1
- script = """set %s %s
- save"""%("/files/etc/dnsmasq.conf/dhcp-host[" + str(cnt) + "]", str(mac) + "," + newIP)
- augtool < script
- #reset dnsmasq
- service("dnsmasq", "restart", stdout=None, stderr=None)
- return newIP
-
- def releaseIP(self, ip):
- dhcp_host = augtool.match("/files/etc/dnsmasq.conf/dhcp-host").stdout.decode('utf-8').strip()
- path = None
- for host in dhcp_host.splitlines():
- if host.find(ip) != -1:
- path = host.split("=")[0].strip()
-
- if path == None:
- print("Can't find " + str(ip) + " in conf file")
- return None
-
- print(path)
- script = """rm %s
- save"""%(path)
- augtool < script
-
- self.availIP.remove(ip)
-
- #reset dnsmasq
- service("dnsmasq", "restart", stdout=None, stderr=None)
+ _instance = None
+
+ def __init__(self):
+ self.availIP = []
+ self.router = None
+ self.netmask = None
+ self.initialized = False
+
+ # Load DHCP options
+ options = augtool.match(f"{DNSMASQ_CONFIG}/dhcp-option").stdout.decode('utf-8').strip()
+ for option in options.splitlines():
+ if "option:router" in option:
+ self.router = option.split("=")[1].strip().split(",")[1]
+ print(self.router)
+
+ # Load DHCP range
+ dhcp_range = augtool.get(f"{DNSMASQ_CONFIG}/dhcp-range").stdout.decode('utf-8').strip()
+ dhcp_start = dhcp_range.split("=")[1].strip().split(",")[0]
+ dhcp_end = dhcp_range.split("=")[1].strip().split(",")[1]
+ self.netmask = dhcp_range.split("=")[1].strip().split(",")[2]
+ print(dhcp_start, dhcp_end, self.netmask)
+
+ # Convert IP range to numbers
+ start_ip_num = self.ipToNum(dhcp_start)
+ end_ip_num = self.ipToNum(dhcp_end)
+ print(start_ip_num, end_ip_num)
+
+ # Populate available IPs
+ for ip in range(start_ip_num, end_ip_num + 1):
+ self.availIP.append(ip)
+ print(self.availIP[0], self.availIP[-1])
+
+ # Load already allocated IPs
+ self.reloadAllocatedIP()
+
+ def ipToNum(self, ip):
+ """Convert IP address string to a number."""
+ return struct.unpack("!I", socket.inet_aton(ip))[0]
+
+ def numToIp(self, num):
+ """Convert a number back to an IP address."""
+ return socket.inet_ntoa(struct.pack('!I', num))
+
+ def getFreeIP(self):
+ """Return the next available IP address."""
+ if len(self.availIP) > 0:
+ ip = self.numToIp(self.availIP.pop(0))
+ return ip
+ else:
+ return None
+
+ def getNetmask(self):
+ return self.netmask
+
+ def getRouter(self):
+ return self.router
+
+ @staticmethod
+ def getInstance():
+ if not dhcp._instance:
+ dhcp._instance = dhcp()
+ return dhcp._instance
+
+ def reloadAllocatedIP(self):
+ """Reload already allocated IPs from the config file."""
+ dhcp_hosts = augtool.match(f"{DNSMASQ_CONFIG}/dhcp-host").stdout.decode('utf-8').strip().splitlines()
+ for host in dhcp_hosts:
+ if "dhcp-host" in host:
+ allocatedIP = self.ipToNum(host.split("=")[1].strip().split(",")[1])
+ if allocatedIP in self.availIP:
+ self.availIP.remove(allocatedIP)
+
+ def allocateIP(self, mac):
+ """Allocate an IP address to the given MAC address."""
+ newIP = self.getFreeIP()
+ dhcp_host = augtool.match(f"{DNSMASQ_CONFIG}/dhcp-host").stdout.decode('utf-8').strip()
+ cnt = len(dhcp_host.splitlines()) + 1
+ script = f"""set {DNSMASQ_CONFIG}/dhcp-host[{cnt}] {mac},{newIP}
+ save"""
+ with open("/path/to/script", "w") as script_file:
Review Comment:
what is the intention here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update cloud-web-ipallocator.py [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #9796:
URL: https://github.com/apache/cloudstack/pull/9796#issuecomment-3645555510
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9796?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 3.58%. Comparing base ([`f417c6b`](https://app.codecov.io/gh/apache/cloudstack/commit/f417c6b0a1d6fcebcdf337e4534aa60d353c8883?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9057860`](https://app.codecov.io/gh/apache/cloudstack/commit/9057860f246b72d41560c3130691fd85b3fe20ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (f417c6b) and HEAD (9057860). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (f417c6b) | HEAD (9057860) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #9796 +/- ##
============================================
- Coverage 17.46% 3.58% -13.88%
============================================
Files 5913 445 -5468
Lines 529385 37552 -491833
Branches 64679 6914 -57765
============================================
- Hits 92448 1347 -91101
+ Misses 426518 36039 -390479
+ Partials 10419 166 -10253
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9796/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9796/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.58% <ø> (ø)` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9796/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9796?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update cloud-web-ipallocator.py [cloudstack]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #9796:
URL: https://github.com/apache/cloudstack/pull/9796#issuecomment-2413056493
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:
- In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
- Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
- Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
- Please follow [ASF Code of Conduct](https://github.com/apache/.github/blob/main/.github/CODE_OF_CONDUCT.md) for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
- Be sure to read the [CloudStack Coding Conventions](https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions).
Apache CloudStack is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@cloudstack.apache.org (https://cloudstack.apache.org/mailing-lists.html)
Slack: https://apachecloudstack.slack.com/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org