[jira] [Commented] (NIFI-2585) Add attributes to track where a flow file came from when receiving over site-to-site

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-2585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15728023#comment-15728023 ] 

ASF GitHub Bot commented on NIFI-2585:
--------------------------------------

GitHub user randerzander opened a pull request:

    https://github.com/apache/nifi/pull/1307

    NIFI-2585: Add attributes to track where a flow file came from when r…

    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    I'm uncertain how to add a unit test for this as I'm not sure why [TestStandardSiteToSiteProtocol](https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/test/java/org/apache/nifi/remote/TestStandardSiteToSiteProtocol.java) is entirely commented out.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/randerzander/nifi master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1307.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1307
    
----
commit ccaa12b4b6e4d648c63a2e1b122a3e37b8f2b505
Author: Randy Gelhausen <rg...@gmail.com>
Date:   2016-12-07T07:18:09Z

    NIFI-2585: Add attributes to track where a flow file came from when receiving over site-to-site

----


> Add attributes to track where a flow file came from when receiving over site-to-site
> ------------------------------------------------------------------------------------
>
>                 Key: NIFI-2585
>                 URL: https://issues.apache.org/jira/browse/NIFI-2585
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Bryan Bende
>            Priority: Minor
>
> With MiNiFi starting be used to send data to a central NiFi, it would be helpful if information about the sending host and port was added to each flow file received over site-to-site. Currently this information is available and used to generate the transit URI in the RECEIVE event, but this information isn't available to downstream processors that might want to make routing decisions.
> For reference:
> https://github.com/apache/nifi/blob/e23b2356172e128086585fe2c425523c3628d0e7/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/main/java/org/apache/nifi/remote/protocol/AbstractFlowFileServerProtocol.java#L452
> A possible approach might be to add two attributes to each flow file, something like "remote.host" and "remote.address" where remote.host has only the sending hostname, and remote.address has the sending host and port.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)