You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Thiruvalluvan M. G. (JIRA)" <ji...@apache.org> on 2009/11/06 18:57:32 UTC
[jira] Created: (AVRO-184) Better eclipse configuration support
Better eclipse configuration support
------------------------------------
Key: AVRO-184
URL: https://issues.apache.org/jira/browse/AVRO-184
Project: Avro
Issue Type: Bug
Components: java
Reporter: Thiruvalluvan M. G.
Assignee: Thiruvalluvan M. G.
Priority: Minor
Jira AVRO-146 enabled easy eclipse setup for Avro. But it had a few minor issues:
- It downloaded the ant-eclipse plug-in directly without using Ivy. This problem has been acknowledged in the JIRA itself. Thus if you clean up the project and rebuild, it'll go and fetch the plug-in again. That means one cannot do "ant clean" when offline.
- Eclipse project used the external jar files from ivy cache locations rather than from the place where they have been retrieved into. It's not a big issue, the only concern is that ant and eclipse will use two different sets of jars though with identical contents.
- Ant-eclipse plug-in was downloaded into build/lib, which will get included in ant builds, though the builds would never use it.
The attached patch fixes all these issues. The ant-eclipse plug-in now gets retrieved by ivy into a separate directory build/lib/ant-eclipse. Unfortunately, the is patch adds a new file ivysettings-ant-eclipse.xml in the base directory. Alas, one cannot specify ivy settings inline in build.xml, you need an external settings file.
There is still one more small problem. Eclipse projects traditionally use the built-in JUnit instead of external jars. The use of built-in JUnit within a project is specified by a classpathentry of kind "con" in the .classpath directory. The projects with JUnit will have two classpathentries of "con" kind - one for JRE and the other for JUnit. But Ant-eclipse does not support more than one classpathentry of "con" kind, which is already used by the JRE. Thus we cannot fix this problem until ant-eclipse removes this limitation.
Eclipse users, please give this patch a try. Thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-184) Better eclipse configuration support
Posted by "Thiruvalluvan M. G. (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774349#action_12774349 ]
Thiruvalluvan M. G. commented on AVRO-184:
------------------------------------------
{quote}
... in the .classpath directory ...
{quote}
I meant the .classpath file.
> Better eclipse configuration support
> ------------------------------------
>
> Key: AVRO-184
> URL: https://issues.apache.org/jira/browse/AVRO-184
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Thiruvalluvan M. G.
> Assignee: Thiruvalluvan M. G.
> Priority: Minor
> Attachments: AVRO-184.patch
>
>
> Jira AVRO-146 enabled easy eclipse setup for Avro. But it had a few minor issues:
> - It downloaded the ant-eclipse plug-in directly without using Ivy. This problem has been acknowledged in the JIRA itself. Thus if you clean up the project and rebuild, it'll go and fetch the plug-in again. That means one cannot do "ant clean" when offline.
> - Eclipse project used the external jar files from ivy cache locations rather than from the place where they have been retrieved into. It's not a big issue, the only concern is that ant and eclipse will use two different sets of jars though with identical contents.
> - Ant-eclipse plug-in was downloaded into build/lib, which will get included in ant builds, though the builds would never use it.
> The attached patch fixes all these issues. The ant-eclipse plug-in now gets retrieved by ivy into a separate directory build/lib/ant-eclipse. Unfortunately, the is patch adds a new file ivysettings-ant-eclipse.xml in the base directory. Alas, one cannot specify ivy settings inline in build.xml, you need an external settings file.
> There is still one more small problem. Eclipse projects traditionally use the built-in JUnit instead of external jars. The use of built-in JUnit within a project is specified by a classpathentry of kind "con" in the .classpath directory. The projects with JUnit will have two classpathentries of "con" kind - one for JRE and the other for JUnit. But Ant-eclipse does not support more than one classpathentry of "con" kind, which is already used by the JRE. Thus we cannot fix this problem until ant-eclipse removes this limitation.
> Eclipse users, please give this patch a try. Thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-184) Better eclipse configuration support
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785533#action_12785533 ]
Doug Cutting commented on AVRO-184:
-----------------------------------
> I have not got the committer access yet.
Your account is now created and you've been given access to commit.
I wish this didn't create a file in the top-level directory. But after AVRO-163 this should move into the java/ tree, so I guess it's okay for now.
The indentation in ivysettings-ant-eclipse.xml appears bad because it uses tabs. Can this be switched to 2-space indentation?
Thiru, as a reminder, when you commit, make sure to:
- run tests first
- add an entry to CHANGES.txt
- name the issue in the commit message
- resolve the issue as fixed
> Better eclipse configuration support
> ------------------------------------
>
> Key: AVRO-184
> URL: https://issues.apache.org/jira/browse/AVRO-184
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Thiruvalluvan M. G.
> Assignee: Thiruvalluvan M. G.
> Priority: Minor
> Attachments: AVRO-184.patch, AVRO-184.patch
>
>
> Jira AVRO-146 enabled easy eclipse setup for Avro. But it had a few minor issues:
> - It downloaded the ant-eclipse plug-in directly without using Ivy. This problem has been acknowledged in the JIRA itself. Thus if you clean up the project and rebuild, it'll go and fetch the plug-in again. That means one cannot do "ant clean" when offline.
> - Eclipse project used the external jar files from ivy cache locations rather than from the place where they have been retrieved into. It's not a big issue, the only concern is that ant and eclipse will use two different sets of jars though with identical contents.
> - Ant-eclipse plug-in was downloaded into build/lib, which will get included in ant builds, though the builds would never use it.
> The attached patch fixes all these issues. The ant-eclipse plug-in now gets retrieved by ivy into a separate directory build/lib/ant-eclipse. Unfortunately, the is patch adds a new file ivysettings-ant-eclipse.xml in the base directory. Alas, one cannot specify ivy settings inline in build.xml, you need an external settings file.
> There is still one more small problem. Eclipse projects traditionally use the built-in JUnit instead of external jars. The use of built-in JUnit within a project is specified by a classpathentry of kind "con" in the .classpath directory. The projects with JUnit will have two classpathentries of "con" kind - one for JRE and the other for JUnit. But Ant-eclipse does not support more than one classpathentry of "con" kind, which is already used by the JRE. Thus we cannot fix this problem until ant-eclipse removes this limitation.
> Eclipse users, please give this patch a try. Thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-184) Better eclipse configuration support
Posted by "Thiruvalluvan M. G. (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thiruvalluvan M. G. updated AVRO-184:
-------------------------------------
Attachment: AVRO-184.patch
{quote}
I've tried applying it, however, and it doesn't seem to work for me
...
Previously, we were downloading ant-eclipse from sourceforge, and now it's going for 101tec, which seems less reliable. Does it work for you?
{quote}
No, no longer. The 101tec server doesn't work.
I've changed the files to download from sourceforge instead.
There is another small problem: "ant clean eclipse" doesn't work. This is because ant checks for an existence of a file to decide to retrieve ant-eclipse or not. This check happens before the target "clean" gets executed. So ant thinks the file exists and does not require to retrieve. But "clean" removes the file. This problem can be fixed by calling the real target within an outer target. But since this is a rare use-case, I've not done that. This problem is not new. It existed even before this patch, but it didn't show up due to a bug, which checked for a wrong file.
{quote}
In terms of the "con" for JUnit-Eclipse, have you found it to make a difference to use Eclipse's built-in Junit?
{quote}
No, I didn't find any specific problem with using external JUnit library.
> Better eclipse configuration support
> ------------------------------------
>
> Key: AVRO-184
> URL: https://issues.apache.org/jira/browse/AVRO-184
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Thiruvalluvan M. G.
> Assignee: Thiruvalluvan M. G.
> Priority: Minor
> Attachments: AVRO-184.patch, AVRO-184.patch
>
>
> Jira AVRO-146 enabled easy eclipse setup for Avro. But it had a few minor issues:
> - It downloaded the ant-eclipse plug-in directly without using Ivy. This problem has been acknowledged in the JIRA itself. Thus if you clean up the project and rebuild, it'll go and fetch the plug-in again. That means one cannot do "ant clean" when offline.
> - Eclipse project used the external jar files from ivy cache locations rather than from the place where they have been retrieved into. It's not a big issue, the only concern is that ant and eclipse will use two different sets of jars though with identical contents.
> - Ant-eclipse plug-in was downloaded into build/lib, which will get included in ant builds, though the builds would never use it.
> The attached patch fixes all these issues. The ant-eclipse plug-in now gets retrieved by ivy into a separate directory build/lib/ant-eclipse. Unfortunately, the is patch adds a new file ivysettings-ant-eclipse.xml in the base directory. Alas, one cannot specify ivy settings inline in build.xml, you need an external settings file.
> There is still one more small problem. Eclipse projects traditionally use the built-in JUnit instead of external jars. The use of built-in JUnit within a project is specified by a classpathentry of kind "con" in the .classpath directory. The projects with JUnit will have two classpathentries of "con" kind - one for JRE and the other for JUnit. But Ant-eclipse does not support more than one classpathentry of "con" kind, which is already used by the JRE. Thus we cannot fix this problem until ant-eclipse removes this limitation.
> Eclipse users, please give this patch a try. Thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-184) Better eclipse configuration support
Posted by "Thiruvalluvan M. G. (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thiruvalluvan M. G. updated AVRO-184:
-------------------------------------
Attachment: (was: AVRO-184.patch)
> Better eclipse configuration support
> ------------------------------------
>
> Key: AVRO-184
> URL: https://issues.apache.org/jira/browse/AVRO-184
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Thiruvalluvan M. G.
> Assignee: Thiruvalluvan M. G.
> Priority: Minor
> Attachments: AVRO-184.patch, AVRO-184.patch
>
>
> Jira AVRO-146 enabled easy eclipse setup for Avro. But it had a few minor issues:
> - It downloaded the ant-eclipse plug-in directly without using Ivy. This problem has been acknowledged in the JIRA itself. Thus if you clean up the project and rebuild, it'll go and fetch the plug-in again. That means one cannot do "ant clean" when offline.
> - Eclipse project used the external jar files from ivy cache locations rather than from the place where they have been retrieved into. It's not a big issue, the only concern is that ant and eclipse will use two different sets of jars though with identical contents.
> - Ant-eclipse plug-in was downloaded into build/lib, which will get included in ant builds, though the builds would never use it.
> The attached patch fixes all these issues. The ant-eclipse plug-in now gets retrieved by ivy into a separate directory build/lib/ant-eclipse. Unfortunately, the is patch adds a new file ivysettings-ant-eclipse.xml in the base directory. Alas, one cannot specify ivy settings inline in build.xml, you need an external settings file.
> There is still one more small problem. Eclipse projects traditionally use the built-in JUnit instead of external jars. The use of built-in JUnit within a project is specified by a classpathentry of kind "con" in the .classpath directory. The projects with JUnit will have two classpathentries of "con" kind - one for JRE and the other for JUnit. But Ant-eclipse does not support more than one classpathentry of "con" kind, which is already used by the JRE. Thus we cannot fix this problem until ant-eclipse removes this limitation.
> Eclipse users, please give this patch a try. Thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-184) Better eclipse configuration support
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784572#action_12784572 ]
Tom White commented on AVRO-184:
--------------------------------
Is this ready to be committed?
> Better eclipse configuration support
> ------------------------------------
>
> Key: AVRO-184
> URL: https://issues.apache.org/jira/browse/AVRO-184
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Thiruvalluvan M. G.
> Assignee: Thiruvalluvan M. G.
> Priority: Minor
> Attachments: AVRO-184.patch, AVRO-184.patch
>
>
> Jira AVRO-146 enabled easy eclipse setup for Avro. But it had a few minor issues:
> - It downloaded the ant-eclipse plug-in directly without using Ivy. This problem has been acknowledged in the JIRA itself. Thus if you clean up the project and rebuild, it'll go and fetch the plug-in again. That means one cannot do "ant clean" when offline.
> - Eclipse project used the external jar files from ivy cache locations rather than from the place where they have been retrieved into. It's not a big issue, the only concern is that ant and eclipse will use two different sets of jars though with identical contents.
> - Ant-eclipse plug-in was downloaded into build/lib, which will get included in ant builds, though the builds would never use it.
> The attached patch fixes all these issues. The ant-eclipse plug-in now gets retrieved by ivy into a separate directory build/lib/ant-eclipse. Unfortunately, the is patch adds a new file ivysettings-ant-eclipse.xml in the base directory. Alas, one cannot specify ivy settings inline in build.xml, you need an external settings file.
> There is still one more small problem. Eclipse projects traditionally use the built-in JUnit instead of external jars. The use of built-in JUnit within a project is specified by a classpathentry of kind "con" in the .classpath directory. The projects with JUnit will have two classpathentries of "con" kind - one for JRE and the other for JUnit. But Ant-eclipse does not support more than one classpathentry of "con" kind, which is already used by the JRE. Thus we cannot fix this problem until ant-eclipse removes this limitation.
> Eclipse users, please give this patch a try. Thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-184) Better eclipse configuration support
Posted by "Thiruvalluvan M. G. (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thiruvalluvan M. G. updated AVRO-184:
-------------------------------------
Attachment: AVRO-184.patch
> Better eclipse configuration support
> ------------------------------------
>
> Key: AVRO-184
> URL: https://issues.apache.org/jira/browse/AVRO-184
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Thiruvalluvan M. G.
> Assignee: Thiruvalluvan M. G.
> Priority: Minor
> Attachments: AVRO-184.patch
>
>
> Jira AVRO-146 enabled easy eclipse setup for Avro. But it had a few minor issues:
> - It downloaded the ant-eclipse plug-in directly without using Ivy. This problem has been acknowledged in the JIRA itself. Thus if you clean up the project and rebuild, it'll go and fetch the plug-in again. That means one cannot do "ant clean" when offline.
> - Eclipse project used the external jar files from ivy cache locations rather than from the place where they have been retrieved into. It's not a big issue, the only concern is that ant and eclipse will use two different sets of jars though with identical contents.
> - Ant-eclipse plug-in was downloaded into build/lib, which will get included in ant builds, though the builds would never use it.
> The attached patch fixes all these issues. The ant-eclipse plug-in now gets retrieved by ivy into a separate directory build/lib/ant-eclipse. Unfortunately, the is patch adds a new file ivysettings-ant-eclipse.xml in the base directory. Alas, one cannot specify ivy settings inline in build.xml, you need an external settings file.
> There is still one more small problem. Eclipse projects traditionally use the built-in JUnit instead of external jars. The use of built-in JUnit within a project is specified by a classpathentry of kind "con" in the .classpath directory. The projects with JUnit will have two classpathentries of "con" kind - one for JRE and the other for JUnit. But Ant-eclipse does not support more than one classpathentry of "con" kind, which is already used by the JRE. Thus we cannot fix this problem until ant-eclipse removes this limitation.
> Eclipse users, please give this patch a try. Thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-184) Better eclipse configuration support
Posted by "Thiruvalluvan M. G. (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thiruvalluvan M. G. updated AVRO-184:
-------------------------------------
Attachment: AVRO-184.patch
> Better eclipse configuration support
> ------------------------------------
>
> Key: AVRO-184
> URL: https://issues.apache.org/jira/browse/AVRO-184
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Thiruvalluvan M. G.
> Assignee: Thiruvalluvan M. G.
> Priority: Minor
> Attachments: AVRO-184.patch, AVRO-184.patch
>
>
> Jira AVRO-146 enabled easy eclipse setup for Avro. But it had a few minor issues:
> - It downloaded the ant-eclipse plug-in directly without using Ivy. This problem has been acknowledged in the JIRA itself. Thus if you clean up the project and rebuild, it'll go and fetch the plug-in again. That means one cannot do "ant clean" when offline.
> - Eclipse project used the external jar files from ivy cache locations rather than from the place where they have been retrieved into. It's not a big issue, the only concern is that ant and eclipse will use two different sets of jars though with identical contents.
> - Ant-eclipse plug-in was downloaded into build/lib, which will get included in ant builds, though the builds would never use it.
> The attached patch fixes all these issues. The ant-eclipse plug-in now gets retrieved by ivy into a separate directory build/lib/ant-eclipse. Unfortunately, the is patch adds a new file ivysettings-ant-eclipse.xml in the base directory. Alas, one cannot specify ivy settings inline in build.xml, you need an external settings file.
> There is still one more small problem. Eclipse projects traditionally use the built-in JUnit instead of external jars. The use of built-in JUnit within a project is specified by a classpathentry of kind "con" in the .classpath directory. The projects with JUnit will have two classpathentries of "con" kind - one for JRE and the other for JUnit. But Ant-eclipse does not support more than one classpathentry of "con" kind, which is already used by the JRE. Thus we cannot fix this problem until ant-eclipse removes this limitation.
> Eclipse users, please give this patch a try. Thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-184) Better eclipse configuration support
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776517#action_12776517 ]
Philip Zeyliger commented on AVRO-184:
--------------------------------------
I tried out the latest patch. Works for me. +1
-- Philip
> Better eclipse configuration support
> ------------------------------------
>
> Key: AVRO-184
> URL: https://issues.apache.org/jira/browse/AVRO-184
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Thiruvalluvan M. G.
> Assignee: Thiruvalluvan M. G.
> Priority: Minor
> Attachments: AVRO-184.patch, AVRO-184.patch
>
>
> Jira AVRO-146 enabled easy eclipse setup for Avro. But it had a few minor issues:
> - It downloaded the ant-eclipse plug-in directly without using Ivy. This problem has been acknowledged in the JIRA itself. Thus if you clean up the project and rebuild, it'll go and fetch the plug-in again. That means one cannot do "ant clean" when offline.
> - Eclipse project used the external jar files from ivy cache locations rather than from the place where they have been retrieved into. It's not a big issue, the only concern is that ant and eclipse will use two different sets of jars though with identical contents.
> - Ant-eclipse plug-in was downloaded into build/lib, which will get included in ant builds, though the builds would never use it.
> The attached patch fixes all these issues. The ant-eclipse plug-in now gets retrieved by ivy into a separate directory build/lib/ant-eclipse. Unfortunately, the is patch adds a new file ivysettings-ant-eclipse.xml in the base directory. Alas, one cannot specify ivy settings inline in build.xml, you need an external settings file.
> There is still one more small problem. Eclipse projects traditionally use the built-in JUnit instead of external jars. The use of built-in JUnit within a project is specified by a classpathentry of kind "con" in the .classpath directory. The projects with JUnit will have two classpathentries of "con" kind - one for JRE and the other for JUnit. But Ant-eclipse does not support more than one classpathentry of "con" kind, which is already used by the JRE. Thus we cannot fix this problem until ant-eclipse removes this limitation.
> Eclipse users, please give this patch a try. Thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-184) Better eclipse configuration support
Posted by "Thiruvalluvan M. G. (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784605#action_12784605 ]
Thiruvalluvan M. G. commented on AVRO-184:
------------------------------------------
I think yes.
I have not got the committer access yet. (I took some time to finish the paperwork). Can some other committer commit this please?
Thanks
> Better eclipse configuration support
> ------------------------------------
>
> Key: AVRO-184
> URL: https://issues.apache.org/jira/browse/AVRO-184
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Thiruvalluvan M. G.
> Assignee: Thiruvalluvan M. G.
> Priority: Minor
> Attachments: AVRO-184.patch, AVRO-184.patch
>
>
> Jira AVRO-146 enabled easy eclipse setup for Avro. But it had a few minor issues:
> - It downloaded the ant-eclipse plug-in directly without using Ivy. This problem has been acknowledged in the JIRA itself. Thus if you clean up the project and rebuild, it'll go and fetch the plug-in again. That means one cannot do "ant clean" when offline.
> - Eclipse project used the external jar files from ivy cache locations rather than from the place where they have been retrieved into. It's not a big issue, the only concern is that ant and eclipse will use two different sets of jars though with identical contents.
> - Ant-eclipse plug-in was downloaded into build/lib, which will get included in ant builds, though the builds would never use it.
> The attached patch fixes all these issues. The ant-eclipse plug-in now gets retrieved by ivy into a separate directory build/lib/ant-eclipse. Unfortunately, the is patch adds a new file ivysettings-ant-eclipse.xml in the base directory. Alas, one cannot specify ivy settings inline in build.xml, you need an external settings file.
> There is still one more small problem. Eclipse projects traditionally use the built-in JUnit instead of external jars. The use of built-in JUnit within a project is specified by a classpathentry of kind "con" in the .classpath directory. The projects with JUnit will have two classpathentries of "con" kind - one for JRE and the other for JUnit. But Ant-eclipse does not support more than one classpathentry of "con" kind, which is already used by the JRE. Thus we cannot fix this problem until ant-eclipse removes this limitation.
> Eclipse users, please give this patch a try. Thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (AVRO-184) Better eclipse configuration support
Posted by "Thiruvalluvan M. G. (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thiruvalluvan M. G. resolved AVRO-184.
--------------------------------------
Resolution: Fixed
Committed revision 887210 incorporating Doug's suggestions.
> Better eclipse configuration support
> ------------------------------------
>
> Key: AVRO-184
> URL: https://issues.apache.org/jira/browse/AVRO-184
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Thiruvalluvan M. G.
> Assignee: Thiruvalluvan M. G.
> Priority: Minor
> Attachments: AVRO-184.patch, AVRO-184.patch
>
>
> Jira AVRO-146 enabled easy eclipse setup for Avro. But it had a few minor issues:
> - It downloaded the ant-eclipse plug-in directly without using Ivy. This problem has been acknowledged in the JIRA itself. Thus if you clean up the project and rebuild, it'll go and fetch the plug-in again. That means one cannot do "ant clean" when offline.
> - Eclipse project used the external jar files from ivy cache locations rather than from the place where they have been retrieved into. It's not a big issue, the only concern is that ant and eclipse will use two different sets of jars though with identical contents.
> - Ant-eclipse plug-in was downloaded into build/lib, which will get included in ant builds, though the builds would never use it.
> The attached patch fixes all these issues. The ant-eclipse plug-in now gets retrieved by ivy into a separate directory build/lib/ant-eclipse. Unfortunately, the is patch adds a new file ivysettings-ant-eclipse.xml in the base directory. Alas, one cannot specify ivy settings inline in build.xml, you need an external settings file.
> There is still one more small problem. Eclipse projects traditionally use the built-in JUnit instead of external jars. The use of built-in JUnit within a project is specified by a classpathentry of kind "con" in the .classpath directory. The projects with JUnit will have two classpathentries of "con" kind - one for JRE and the other for JUnit. But Ant-eclipse does not support more than one classpathentry of "con" kind, which is already used by the JRE. Thus we cannot fix this problem until ant-eclipse removes this limitation.
> Eclipse users, please give this patch a try. Thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-184) Better eclipse configuration support
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774507#action_12774507 ]
Philip Zeyliger commented on AVRO-184:
--------------------------------------
This patch makes a lot of sense. I agree with all of the fixes.
I've tried applying it, however, and it doesn't seem to work for me:
{noformat}
[ivy:retrieve]
[ivy:retrieve] :: problems summary ::
[ivy:retrieve] :::: WARNINGS
[ivy:retrieve] module not found: ant-eclipse#ant-eclipse;1.0
[ivy:retrieve] ==== ant-eclipse: tried
[ivy:retrieve] http://oss.101tec.com/nexus/content/groups/public/ant-eclipse/ant-eclipse/1.0/ant-eclipse-1.0.pom
[ivy:retrieve] -- artifact ant-eclipse#ant-eclipse;1.0!ant-eclipse-jvm1.2.jar:
[ivy:retrieve] http://oss.101tec.com/nexus/content/groups/public/ant-eclipse/ant-eclipse-jvm1.2/1.0/ant-eclipse-jvm1.2-1.0.jar
[ivy:retrieve] ::::::::::::::::::::::::::::::::::::::::::::::
[ivy:retrieve] :: UNRESOLVED DEPENDENCIES ::
[ivy:retrieve] ::::::::::::::::::::::::::::::::::::::::::::::
[ivy:retrieve] :: ant-eclipse#ant-eclipse;1.0: not found
[ivy:retrieve] ::::::::::::::::::::::::::::::::::::::::::::::
[ivy:retrieve] :::: ERRORS
[ivy:retrieve] SERVER ERROR: Service Temporarily Unavailable url=http://oss.101tec.com/nexus/content/groups/public/ant-eclipse/ant-eclipse/1.0/ant-eclipse-1.0.pom
[ivy:retrieve] SERVER ERROR: Service Temporarily Unavailable url=http://oss.101tec.com/nexus/content/groups/public/ant-eclipse/ant-eclipse-jvm1.2/1.0/ant-eclipse-jvm1.2-1.0.jar
[ivy:retrieve]
[ivy:retrieve] :: USE VERBOSE OR DEBUG MESSAGE LEVEL FOR MORE DETAILS
{noformat}
Previously, we were downloading ant-eclipse from sourceforge, and now it's going for 101tec, which seems less reliable. Does it work for you?
In terms of the "con" for JUnit-Eclipse, have you found it to make a difference to use Eclipse's built-in Junit? We could certainly make that happen with some sed-magic after ant-eclipse runs.
> Better eclipse configuration support
> ------------------------------------
>
> Key: AVRO-184
> URL: https://issues.apache.org/jira/browse/AVRO-184
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Thiruvalluvan M. G.
> Assignee: Thiruvalluvan M. G.
> Priority: Minor
> Attachments: AVRO-184.patch
>
>
> Jira AVRO-146 enabled easy eclipse setup for Avro. But it had a few minor issues:
> - It downloaded the ant-eclipse plug-in directly without using Ivy. This problem has been acknowledged in the JIRA itself. Thus if you clean up the project and rebuild, it'll go and fetch the plug-in again. That means one cannot do "ant clean" when offline.
> - Eclipse project used the external jar files from ivy cache locations rather than from the place where they have been retrieved into. It's not a big issue, the only concern is that ant and eclipse will use two different sets of jars though with identical contents.
> - Ant-eclipse plug-in was downloaded into build/lib, which will get included in ant builds, though the builds would never use it.
> The attached patch fixes all these issues. The ant-eclipse plug-in now gets retrieved by ivy into a separate directory build/lib/ant-eclipse. Unfortunately, the is patch adds a new file ivysettings-ant-eclipse.xml in the base directory. Alas, one cannot specify ivy settings inline in build.xml, you need an external settings file.
> There is still one more small problem. Eclipse projects traditionally use the built-in JUnit instead of external jars. The use of built-in JUnit within a project is specified by a classpathentry of kind "con" in the .classpath directory. The projects with JUnit will have two classpathentries of "con" kind - one for JRE and the other for JUnit. But Ant-eclipse does not support more than one classpathentry of "con" kind, which is already used by the JRE. Thus we cannot fix this problem until ant-eclipse removes this limitation.
> Eclipse users, please give this patch a try. Thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.