You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Josh Elser (JIRA)" <ji...@apache.org> on 2019/04/04 14:28:00 UTC
[jira] [Commented] (PHOENIX-5228) phoenix uses slf4j for logging in
many class files
[ https://issues.apache.org/jira/browse/PHOENIX-5228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809909#comment-16809909 ]
Josh Elser commented on PHOENIX-5228:
-------------------------------------
{quote}It would be good to change slf4j to apache log4j.
{quote}
Do you mean change from Log4j to slf4j? I don't know why you would want to go from a facade to a specific logging implementation. I would -1 that idea.
> phoenix uses slf4j for logging in many class files
> --------------------------------------------------
>
> Key: PHOENIX-5228
> URL: https://issues.apache.org/jira/browse/PHOENIX-5228
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.14.1, 5.1.0
> Reporter: Monani Mihir
> Priority: Trivial
>
> It would be good to change slf4j to apache log4j. Here is list of files where we use slf4j instead of apache log4j.
> phoenix-core :-
> {noformat}
> BaseTest.java
> UpsertSelectOverlappingBatchesIT.java
> ConnectionQueryServicesTestImpl.java
> PartialScannerResultsDisabledIT.java
> End2EndTestDriver.java
> BaseQueryIT.java
> TableSnapshotReadsMapReduceIT.java
> OrphanViewToolIT.java
> PartialIndexRebuilderIT.java
> Sandbox.java
> ConnectionCachingIT.java
> ScanPlan.java
> AggregatePlan.java
> MutationState.java
> FirstLastValueServerAggregator.java
> SizeTrackingServerAggregators.java
> LikeExpression.java
> PhoenixCanaryTool.java
> RowKeyComparisonFilter.java
> UpdateStatisticsTool.java
> MetaDataClient.java
> SpillFile.java
> SpillableGroupByCache.java
> TenantCacheImpl.java
> GlobalCache.java
> GlobalMemoryManager.java
> FromCompiler.java
> PhoenixDriver.java
> PhoenixStatement.java
> PhoenixEmbeddedDriver.java
> FormatToBytesWritableMapper.java
> FormatToKeyValueReducer.java
> PhoenixTextInputFormat.java
> OrphanViewTool.java
> MultiHfileOutputFormat.java
> PhoenixIndexPartialBuildMapper.java
> IndexScrutinyMapper.java
> IndexScrutinyTool.java
> PhoenixServerBuildIndexMapper.java
> PhoenixIndexImportDirectReducer.java
> IndexTool.java
> PhoenixIndexImportMapper.java
> DirectHTableWriter.java
> PhoenixIndexImportDirectMapper.java
> IndexToolUtil.java
> RegexToKeyValueMapper.java
> AbstractBulkLoadTool.java
> GlobalClientMetrics.java
> ReadOnlyProps.java
> CSVCommonsLoader.java
> CsvUpsertExecutor.java
> JsonUpsertExecutor.java
> RegexUpsertExecutor.java
> UpsertExecutor.java
> UpgradeUtil.java
> MetaDataUtil.java
> Closeables.java
> GuidePostsCache.java
> PhoenixStatsCacheLoader.java
> ConnectionQueryServicesImpl.java
> GroupedAggregateRegionObserver.java
> MetaDataEndpointImpl.java
> UngroupedAggregateRegionObserver.java
> OmidTransactionContext.java
> TephraTransactionContext.java
> ChunkedResultIterator.java
> ParallelIterators.java
> RoundRobinResultIterator.java
> BaseResultIterators.java
> TableResultIterator.java{noformat}
> phoenix-pherf :-
> {noformat}
> XMLResultHandlerTest.java
> ConfigurationParserTest.java
> XMLConfigParserTest.java
> RulesApplier.java
> SchemaReader.java
> ResultManager.java
> XMLConfigParser.java
> Pherf.java
> ResourceList.java
> PhoenixUtil.java
> WriteWorkload.java
> QueryVerifier.java
> MultiThreadedRunner.java
> WorkloadExecutor.java
> QueryExecutor.java
> MultithreadedDiffer.java
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)