You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/06/15 12:30:28 UTC

[GitHub] [ignite] zstan commented on a change in pull request #7906: IGNITE-6499 : Compact NULL fields binary representation

zstan commented on a change in pull request #7906:
URL: https://github.com/apache/ignite/pull/7906#discussion_r440140869



##########
File path: modules/core/src/test/java/org/apache/ignite/internal/binary/BinaryMarshallerSelfTest.java
##########
@@ -3851,9 +3851,16 @@ protected boolean compactFooter() {
     }
 
     /**
-     * @param marsh Marshaller.
-     * @return Binary context.
+     * @return  Whether to use null compaction or not.
      */
+    protected boolean compactNull() {
+        return false;
+    }
+
+        /**
+         * @param marsh Marshaller.

Review comment:
       aligning




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org