You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Juergen Donnerstag (JIRA)" <ji...@apache.org> on 2010/11/14 09:36:13 UTC

[jira] Commented: (WICKET-2713) Locate .properties files using the same convention as markup files

    [ https://issues.apache.org/jira/browse/WICKET-2713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931791#action_12931791 ] 

Juergen Donnerstag commented on WICKET-2713:
--------------------------------------------

I tried to fix it but the problem where I didn't find an easy solution for is that the properties search doesn't stop when a resource file was found (not necessary for markup resources). It stops when the correct property get found. Hence the search must continue if no the property was found in the properties resource. That requirements calls for an iterator and actually we have that iterator already (ResourceNameIterator). And it already is used consistently. With that we only needed a "factory" to create the RNI. A place which you can use to intercept. I've added a newRNI method to IResourceStreamLocator and changed existing code to call that method.

> Locate .properties files using the same convention as markup files
> ------------------------------------------------------------------
>
>                 Key: WICKET-2713
>                 URL: https://issues.apache.org/jira/browse/WICKET-2713
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Swulius
>            Assignee: Juergen Donnerstag
>            Priority: Minor
>             Fix For: 1.5-M4
>
>
> original inquiry on mailing list
> http://www.mail-archive.com/users@wicket.apache.org/msg47803.html
> --
> I am curious.  Why are .properties files not located in the same way as .html?  I've overridden:
> [ResourceStreamLocator]
> public IResourceStream locate( Class<?> clazz, String aPath, String aStyle, Locale aLocale, String anExtension )
> I notice that property file locating doesn't invoke this method, but only invokes the lesser arg version with the style/variation/locale already embedded in the path.  This is an inconvenience for me because I'm trying to inspect the style during location.  Perhaps I shouldn't be doing what I'm trying to do, but after reading the docs, I expected locating to work the way it does for .html, but .properties threw me.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.