You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "liuxiaocs7 (via GitHub)" <gi...@apache.org> on 2026/09/04 09:12:25 UTC
[I] Custom model context window requires a second save to persist [maka]
liuxiaocs7 opened a new issue, #4755:
URL: https://github.com/apache/maka/issues/4755
## What happened
Editing the declared context window for a custom model and clicking **Save** once can persist the previous value instead of the value currently shown in the input. As a result, the usage view can still report that the context limit is unknown or continue using the stale limit.
Expected behavior: the value displayed in the context-window input is persisted by the first Save click.
## How to reproduce
1. Open **Settings → Models** and select a custom OpenAI-compatible connection.
2. Add a custom model with a context window such as `128000`.
3. Open that model's capability settings.
4. Change the context window to `258000`.
5. Without clicking elsewhere first, click **Save** once.
6. Read the connection snapshot or reopen the settings.
The saved `relayModelProfiles[modelId].contextWindow` remains `128000`. A second Save persists `258000`.
## Environment
- Maka commit: `2bdabbe62`
- OS: macOS 15.7.3
- Surface: Desktop
- Node.js: v24.14.0
## Logs, screenshots, or additional context
`NumberInput` already buffers text and commits it on blur/Enter. `DeclaredContextWindowField` adds another local draft and commit boundary, so the blur caused by clicking Save updates only the inner draft while the row-level Save reads the previous value.
A deterministic Electron E2E reproduces the defect by changing `128000` to `258000`, clicking Save once, and asserting the persisted connection snapshot.
_Submitted with Codex assistance on behalf of @liuxiaocs7._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [I] Custom model context window requires a second save to persist [maka]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on issue #4755:
URL: https://github.com/apache/maka/issues/4755#issuecomment-5538282027
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [I] Custom model context window requires a second save to persist [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han closed issue #4755: Custom model context window requires a second save to persist
URL: https://github.com/apache/maka/issues/4755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org