You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/05/06 13:30:53 UTC

[GitHub] [flink] tillrohrmann opened a new pull request #15849: [FLINK-22577][tests] Harden KubernetesLeaderElectionAndRetrievalITCase

tillrohrmann opened a new pull request #15849:
URL: https://github.com/apache/flink/pull/15849


   This commit introduces closing logic to the TestingLeaderElectionEventHandler which would
   otherwise forward calls after the KubernetesLeaderElectionDriver is closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15849: [FLINK-22577][tests] Harden KubernetesLeaderElectionAndRetrievalITCase

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15849:
URL: https://github.com/apache/flink/pull/15849#issuecomment-833559648


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "666fc82984218fc36f4d3a8a49f9e006641fc5b1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17642",
       "triggerID" : "666fc82984218fc36f4d3a8a49f9e006641fc5b1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 666fc82984218fc36f4d3a8a49f9e006641fc5b1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17642) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15849: [FLINK-22577][tests] Harden KubernetesLeaderElectionAndRetrievalITCase

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15849:
URL: https://github.com/apache/flink/pull/15849#issuecomment-833559648


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "666fc82984218fc36f4d3a8a49f9e006641fc5b1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17642",
       "triggerID" : "666fc82984218fc36f4d3a8a49f9e006641fc5b1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "07aac793a06614501d9e0a60efe9b7e17ade9699",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17703",
       "triggerID" : "07aac793a06614501d9e0a60efe9b7e17ade9699",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 666fc82984218fc36f4d3a8a49f9e006641fc5b1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17642) 
   * 07aac793a06614501d9e0a60efe9b7e17ade9699 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17703) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15849: [FLINK-22577][tests] Harden KubernetesLeaderElectionAndRetrievalITCase

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15849:
URL: https://github.com/apache/flink/pull/15849#issuecomment-833559648


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "666fc82984218fc36f4d3a8a49f9e006641fc5b1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17642",
       "triggerID" : "666fc82984218fc36f4d3a8a49f9e006641fc5b1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "07aac793a06614501d9e0a60efe9b7e17ade9699",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "07aac793a06614501d9e0a60efe9b7e17ade9699",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 666fc82984218fc36f4d3a8a49f9e006641fc5b1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17642) 
   * 07aac793a06614501d9e0a60efe9b7e17ade9699 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann closed pull request #15849: [FLINK-22577][tests] Harden KubernetesLeaderElectionAndRetrievalITCase

Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #15849:
URL: https://github.com/apache/flink/pull/15849


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on pull request #15849: [FLINK-22577][tests] Harden KubernetesLeaderElectionAndRetrievalITCase

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #15849:
URL: https://github.com/apache/flink/pull/15849#issuecomment-836503183


   Thanks for the review @wangyang0918. Failures seem to be unrelated. Merging this PR now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #15849: [FLINK-22577][tests] Harden KubernetesLeaderElectionAndRetrievalITCase

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15849:
URL: https://github.com/apache/flink/pull/15849#issuecomment-833527463


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 666fc82984218fc36f4d3a8a49f9e006641fc5b1 (Thu May 06 13:34:27 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15849: [FLINK-22577][tests] Harden KubernetesLeaderElectionAndRetrievalITCase

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15849:
URL: https://github.com/apache/flink/pull/15849#issuecomment-833559648


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "666fc82984218fc36f4d3a8a49f9e006641fc5b1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17642",
       "triggerID" : "666fc82984218fc36f4d3a8a49f9e006641fc5b1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 666fc82984218fc36f4d3a8a49f9e006641fc5b1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17642) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15849: [FLINK-22577][tests] Harden KubernetesLeaderElectionAndRetrievalITCase

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15849:
URL: https://github.com/apache/flink/pull/15849#issuecomment-833559648


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "666fc82984218fc36f4d3a8a49f9e006641fc5b1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17642",
       "triggerID" : "666fc82984218fc36f4d3a8a49f9e006641fc5b1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "07aac793a06614501d9e0a60efe9b7e17ade9699",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17703",
       "triggerID" : "07aac793a06614501d9e0a60efe9b7e17ade9699",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 07aac793a06614501d9e0a60efe9b7e17ade9699 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17703) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #15849: [FLINK-22577][tests] Harden KubernetesLeaderElectionAndRetrievalITCase

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15849:
URL: https://github.com/apache/flink/pull/15849#issuecomment-833559648


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "666fc82984218fc36f4d3a8a49f9e006641fc5b1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "666fc82984218fc36f4d3a8a49f9e006641fc5b1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 666fc82984218fc36f4d3a8a49f9e006641fc5b1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on pull request #15849: [FLINK-22577][tests] Harden KubernetesLeaderElectionAndRetrievalITCase

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #15849:
URL: https://github.com/apache/flink/pull/15849#issuecomment-834515190


   Thanks for the review @wangyang0918. I think your suggestion makes a lot of sense. I will update the PR accordingly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15849: [FLINK-22577][tests] Harden KubernetesLeaderElectionAndRetrievalITCase

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15849:
URL: https://github.com/apache/flink/pull/15849#issuecomment-833527463


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 07aac793a06614501d9e0a60efe9b7e17ade9699 (Sat Aug 28 11:19:08 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org