You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/17 16:19:22 UTC
[GitHub] [airflow] raphaelauv opened a new pull request #17061: [FIX] Docker provider - retry docker in docker
raphaelauv opened a new pull request #17061:
URL: https://github.com/apache/airflow/pull/17061
Fix https://github.com/apache/airflow/issues/17037#issuecomment-881919794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] raphaelauv edited a comment on pull request #17061: [FIX] Docker provider - retry docker in docker
Posted by GitBox <gi...@apache.org>.
raphaelauv edited a comment on pull request #17061:
URL: https://github.com/apache/airflow/pull/17061#issuecomment-881941311
I can't since there is this line
https://github.com/apache/airflow/blob/675db5c59768e628619a190eb9030f41ebb86fe8/tests/providers/docker/operators/test_docker.py#L42
the name of the tempdir is not the own asked then the if (line 255) never match then it re-raise the except making fail the test
I would prefer to remove this retry logic and add an option
default_local_mount = True
So users of docker in docker could put it at False
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] raphaelauv commented on pull request #17061: [FIX] Docker provider - retry docker in docker
Posted by GitBox <gi...@apache.org>.
raphaelauv commented on pull request #17061:
URL: https://github.com/apache/airflow/pull/17061#issuecomment-881941311
I can't since there is this line
https://github.com/apache/airflow/blob/675db5c59768e628619a190eb9030f41ebb86fe8/tests/providers/docker/operators/test_docker.py#L42
the name of the tempdir is not the own asked then the if never match then it reraise the except
I would prefer to remove this retry logic and add an option
default_local_mount = True
So users of docker in docker could put it at False
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17061: [FIX] Docker provider - retry docker in docker
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17061:
URL: https://github.com/apache/airflow/pull/17061#issuecomment-881951433
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] raphaelauv edited a comment on pull request #17061: [FIX] Docker provider - retry docker in docker
Posted by GitBox <gi...@apache.org>.
raphaelauv edited a comment on pull request #17061:
URL: https://github.com/apache/airflow/pull/17061#issuecomment-881941311
I can't since there is this line
https://github.com/apache/airflow/blob/675db5c59768e628619a190eb9030f41ebb86fe8/tests/providers/docker/operators/test_docker.py#L42
the name of the tempdir is not the own asked then the if (line 255) never match then it re-raise the except making fail the test
I would prefer to remove this retry logic
since users of docker in docker can put
mount_tmp_dir = False
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17061: [FIX] Docker provider - retry docker in docker
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17061:
URL: https://github.com/apache/airflow/pull/17061#issuecomment-882054962
Transient errors only. Thanks! @raphaelauv !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] raphaelauv removed a comment on pull request #17061: [FIX] Docker provider - retry docker in docker
Posted by GitBox <gi...@apache.org>.
raphaelauv removed a comment on pull request #17061:
URL: https://github.com/apache/airflow/pull/17061#issuecomment-881941311
I can't since there is this line
https://github.com/apache/airflow/blob/675db5c59768e628619a190eb9030f41ebb86fe8/tests/providers/docker/operators/test_docker.py#L42
the name of the tempdir is not the own asked then the if (line 255) never match then it re-raise the except making fail the test
I would prefer to remove this retry logic
since users of docker in docker can put
mount_tmp_dir = False
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #17061: [FIX] Docker provider - retry docker in docker
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17061:
URL: https://github.com/apache/airflow/pull/17061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17061: [FIX] Docker provider - retry docker in docker
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17061:
URL: https://github.com/apache/airflow/pull/17061#issuecomment-881951514
Let's see the tests . Thanks for the fix. In my tests I had "tmp_dir" and missed the obvious case with None :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17061: [FIX] Docker provider - retry docker in docker
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17061:
URL: https://github.com/apache/airflow/pull/17061#issuecomment-881935677
Ah yeah. My bad. But the test is failing. Can you fix it please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] raphaelauv edited a comment on pull request #17061: [FIX] Docker provider - retry docker in docker
Posted by GitBox <gi...@apache.org>.
raphaelauv edited a comment on pull request #17061:
URL: https://github.com/apache/airflow/pull/17061#issuecomment-881941311
I can't since there is this line
https://github.com/apache/airflow/blob/675db5c59768e628619a190eb9030f41ebb86fe8/tests/providers/docker/operators/test_docker.py#L42
the name of the tempdir is not the own asked then the if (line 255) never match then it re-raise the except making fail the test
I would prefer to remove this retry logic and add an option
```python
default_local_mount = True
```
So users of docker in docker could put it at False
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org