You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2016/08/02 09:47:48 UTC
[GitHub] zeppelin pull request #1260: ZEPPELIN-1267. PySparkInterpreter doesn't work ...
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/1260
ZEPPELIN-1267. PySparkInterpreter doesn't work in spark 2.0
### What is this PR for?
PySparkInterpreter doesn't work in spark 2.0 because pyspark and py4j is not distributed to executors. This PR extract the setup staff for pyspark interpreter into method setupConfForPySpark and use it for both spark1 and spark2. But this is just a short term solution, as I think this should be handled by spark rather than zeppelin, here zeppelin duplicate part of spark's work. In the long term, I'd like to resolve it in `ZEPPELIN-1263`.
### What type of PR is it?
[Bug Fix]
### Todos
* https://issues.apache.org/jira/browse/ZEPPELIN-1263
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1267
### How should this be tested?
Verify it manually.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1267
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1260.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1260
----
commit 81d1d56c94934dd6c4b32144d810626356ce3c0e
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-08-02T09:41:21Z
ZEPPELIN-1267. PySparkInterpreter doesn't work in spark 2.0
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1260: ZEPPELIN-1267. PySparkInterpreter doesn't work in spar...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1260
@zjffdu thank you for quick response, I was able to reproduce it and tested this patch fixes the issue!
Merge if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1260: ZEPPELIN-1267. PySparkInterpreter doesn't work in spar...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1260
Let's merge if there is no further discussion!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1260: ZEPPELIN-1267. PySparkInterpreter doesn't work in spar...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1260
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1260: ZEPPELIN-1267. PySparkInterpreter doesn't work ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1260
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1260: ZEPPELIN-1267. PySparkInterpreter doesn't work in spar...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1260
\cc @jongyoul for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1260: ZEPPELIN-1267. PySparkInterpreter doesn't work in spar...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1260
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1260: ZEPPELIN-1267. PySparkInterpreter doesn't work in spar...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1260
@zjffdu I tried current master branch with master set to local[*], Spark standalone and yarn-client both with/without `SPARK_HOME` set. But somehow I was able to run pyspark interpreter without this patch. I don't know what I missed, could you tell me which environment should I try to make pyspark interpreter fail on master branch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1260: ZEPPELIN-1267. PySparkInterpreter doesn't work in spar...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1260
I also use the latest master and build zeppelin with this command:
```mvn clean package -Pspark-2.0 -Ppyspark -Psparkr -DskipTests
```, and then export `SPARK_HOME` to where spark-2.0 is located and run pyspark interpreter using `yarn-client` mode.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---